Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link updating cannot be restricted for built-in types #164587

Closed
weinand opened this issue Oct 25, 2022 · 1 comment · Fixed by #164766
Closed

link updating cannot be restricted for built-in types #164587

weinand opened this issue Oct 25, 2022 · 1 comment · Fixed by #164766
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders markdown Markdown support issues verified Verification succeeded
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Oct 25, 2022

Testing #164522

By using a glob pattern /foo/**/*.x for the markdown.updateLinksOnFileMove.externalFileGlobs setting, it is possible to restrict link updating only to files inside the foo folder.

The same is not possible for the built-in file types "md" (and common image file formats).

Wouldn't it make sense to support overriding the built-in types?

E.g.:

  • if the markdown.updateLinksOnFileMove.externalFileGlobs setting is used, then all built-in types are ignored, or
  • if a specific built-in type is used for the setting (e.g. /doc/**/*.md), it takes precedence over the built-in one (**/*.md).
@mjbvz mjbvz modified the milestone: October 2022 Oct 26, 2022
@mjbvz
Copy link
Collaborator

mjbvz commented Oct 26, 2022

I think this makes sense. I'm going to rename this setting and also include the markdown file extensions in the new default value

@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues labels Oct 26, 2022
mjbvz added a commit to mjbvz/vscode that referenced this issue Oct 26, 2022
Fixes microsoft#164587

This changes the `externalFileGlobs` setting to instead be a include array of globs that should trigger link updates. I've split the globs into markdown files and image/video files

This also makes it easier for users to add their own new globs to the list
mjbvz added a commit that referenced this issue Oct 26, 2022
* Rework markdown update link glob

Fixes #164587

This changes the `externalFileGlobs` setting to instead be a include array of globs that should trigger link updates. I've split the globs into markdown files and image/video files

This also makes it easier for users to add their own new globs to the list

* Fix scopes
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 26, 2022
formigoni pushed a commit to formigoni/vscode that referenced this issue Oct 27, 2022
* Rework markdown update link glob

Fixes microsoft#164587

This changes the `externalFileGlobs` setting to instead be a include array of globs that should trigger link updates. I've split the globs into markdown files and image/video files

This also makes it easier for users to add their own new globs to the list

* Fix scopes
@andreamah andreamah added the verified Verification succeeded label Oct 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders markdown Markdown support issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants