Reduce unused exports #164933
Assignees
Labels
engineering
VS Code - Build / issue tracking / etc.
Comments
|
For the workbench.web.api.ts file, all those are still needed. For the other files attached to my name, I removed the |
alexr00
added a commit
that referenced
this issue
Nov 1, 2022
|
I wenrt through the list. Removed the ones I marked with ✔️. I kept the ones I marked with 'api', as these are types that are part of an exported API and should stay available. They are also just types and interfaces, so have no impact on the built bits |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
@rebornix and I were wondering if there is any dead code in the VS Code codebase, and one idea was to detect unused exports across the codebase, since unused variables are flagged by the compiler but unused exports are not.
I ran
ts-unused-exportson our sources and generated the following list. I've already done a pass to remove some false positives but apologies if several remain.NB: The primary purpose of this issue is to identify unused functions and classes which aren't being picked up by the compiler because they're exported and which can be safely deleted from our sources to reduce our bundle size. A secondary benefit is to remove unused types and interfaces, e.g. anything which was exported at one point and then ceased to be referenced from other files (which more impacts compile time for dev workflows and pipeline runs, and maybe TS server analysis time, but has no direct impact on bundle size since types are erased).
If you export a type or interface that is not currently actively imported, but is used in the public API of a class that you expose, then it's quite likely that you want to keep that type/interface exported and need not un-export it as part of this issue.
Please feel free to remove your assignment if you find that this isn't valuable.
IHoverContentIIconRegistrygetClassNamesArrayiconStartMarkerExtensionVirtualWorkspaceSupportIIconFiltercssEscapeFoldingModelChangeEventID_INDENT_PROVIDERRangesCollectorID_SYNTAX_PROVIDERRangesCollectoreditorMarkerNavigationErroreditorMarkerNavigationErrorHeadereditorMarkerNavigationWarningeditorMarkerNavigationInfoeditorMarkerNavigationInfoHeadereditorMarkerNavigationBackgroundeditorHoverWidgetHighlightForegroundeditorSuggestWidgetBackgroundeditorSuggestWidgetBordereditorSuggestWidgetForegroundeditorSuggestWidgetSelectedForegroundeditorSuggestWidgetSelectedIconForegroundeditorSuggestWidgetSelectedBackgroundeditorSuggestWidgetHighlightForegroundeditorSuggestWidgetHighlightFocusForegroundeditorSuggestWidgetStatusForegroundsuggestMoreInfoIcondefineThemesetThemegetEncodedLanguageIdIEncodedLineTokensEncodedTokensProviderCodeActionContextShutdownEventIIconsStyleSheetIconIdentifierIconDefaultsIconFontContributionIThemingParticipantTOKEN_TYPE_WILDCARDTOKEN_CLASSIFIER_LANGUAGE_SEPARATORCLASSIFIER_MODIFIER_SEPARATORTokenClassificationStringidPatternselectorPatternTokenSelectorTokenTypeOrModifierContributionTokenStyleFunctionTokenStyleDefaultsSemanticTokenDefaultRuleExtensionsTestFileIconThemeUnthemedProductIconThemeOpenCommandPipeArgsOpenExternalCommandPipeArgsStatusPipeArgsExtensionManagementPipeArgsdebugExceptionWidgetBorderdebugExceptionWidgetBackgroundsettingsGroupExpandedIconsettingsGroupCollapsedIconsettingsAddIconeditorGutterAddedBackgroundeditorGutterDeletedBackgroundminimapGutterModifiedBackgroundminimapGutterAddedBackgroundminimapGutterDeletedBackgroundoverviewRulerModifiedForegroundoverviewRulerAddedForegroundoverviewRulerDeletedForegroundscmProviderSeparatorBorderColorsearchEditorTextInputBorderembeddedEditorBackgroundgetWorkspaceIdentifiertextmateColorSettingsSchemaIdparseWithLocationThemeChangeEventIThemeDataIThemeScopedColorCustomizationsIThemeScopedTokenColorCustomizationsIThemeScopedSemanticTokenColorCustomizationsIThemeScopedExperimentalSemanticTokenColorCustomizationsIExperimentalSemanticTokenColorCustomizationsITokenColorizationSettingExtensionVersionnewTerminalIconenvwindowcommandsloggerTaskDefinitionDTOTaskPresentationOptionsDTOProcessExecutionOptionsDTOProcessExecutionDTOShellExecutionOptionsDTOShellExecutionDTOTaskGroupDTOTaskFilterDTOTaskExecutionDTOVerifiedTaskThe text was updated successfully, but these errors were encountered: