Reduce unused exports #164939
Assignees
Labels
Milestone
Comments
|
Thanks @joyceerhl! For a quick review, so far all of mine were have been for types that were not being directly used outside of the defining file. They were however being referenced indirectly in the file, such as as parameter to public functions or as return types Probably still good to remove them in case a future refactoring renders them unused |
mjbvz
added a commit
to mjbvz/vscode
that referenced
this issue
Oct 28, 2022
mjbvz
added a commit
that referenced
this issue
Oct 29, 2022
meganrogge
added a commit
that referenced
this issue
Oct 31, 2022
meganrogge
added a commit
that referenced
this issue
Oct 31, 2022
|
cc @andreamah for search and @rzhao271 for settings editor |
Merged
roblourens
added a commit
that referenced
this issue
Nov 1, 2022
roblourens
added a commit
that referenced
this issue
Nov 1, 2022
rebornix
added a commit
that referenced
this issue
Nov 1, 2022
|
@joyceerhl thanks for thorough analysis. It's useful in quite a few scenarios but some are false positive, here is what I found It works really well with:
But it's unnecessary and sometimes potentially harmful when:
Like we discussed offline, it might require each owner to make their own judgement |
rebornix
added a commit
that referenced
this issue
Nov 1, 2022
rebornix
added a commit
that referenced
this issue
Nov 1, 2022
rebornix
added a commit
that referenced
this issue
Nov 1, 2022
rzhao271
added a commit
that referenced
this issue
Nov 3, 2022
rzhao271
added a commit
that referenced
this issue
Nov 3, 2022
VSCodeTriageBot
added
unreleased
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
@rebornix and I were wondering if there is any dead code in the VS Code codebase, and one idea was to detect unused exports across the codebase, since unused variables are flagged by the compiler but unused exports are not.
I ran
ts-unused-exportson our sources and generated the following list. I've already done a pass to remove some false positives but apologies if several remain. From a quick sanity check, several of these are indeed not used outside of the file they are declared in and do not need to be exported. Please feel free to remove your assignment if you find that this isn't valuable.ITerminalProfileTypeTaskDefinitionRegistryImplITerminalDecorationDataIndexTreeIDataTransferFileIKeyIteratormaincreateFileDataTransferItemFromFileIEditorContributionCtorIDiffEditorContributionCtorProxyCommandResolveCodeActionKeybindingTriggeredCodeActionTriggerModifierIEditorHoverParticipantCtorSuggestTriggerContextICommandsMapICommandsMapIDragAndDropContributionIWebviewEditorICodeActionContributionActionICodeActionContributionPickExtHostStatusBarEntryreviveOptionsCodeActionExtensionPointFieldsDocumentationExtensionPointFieldsRefactoringDocumentationExtensionPointCustomEditorInputInitInfoINotebookPreloadContributionDirtyDiffControllerDirtyDiffModelexperimentalgetActiveWebviewEditorWebviewResolverIWebviewViewResolverTokenTypesContributionPointerEventHandlerDecorationSubTypeOptionsProviderDecorationTypeOptionsProviderAverageBufferSizecreateUintArrayLineStartsNodePositionBufferCursorIReverseSingleEditOperationPieceTreeTextBufferFactorycalculateSizecalculateLFresetSentinelleftRotaterightRotaterecomputeTreeMetadataFindWidgetViewZoneISimpleButtonOptsgetRandomIntgetRandomEOLSequencegetRandomStringgenerateRandomChunkWithLFINotebookEntryExtHostDocumentLinecreateKernelIdINotebookCommentThreadChangedEventICommentControllerCOMMENTEDITOR_DECORATION_KEYisMouseUpEventMatchMouseDownCommentsAsyncDataSourceResourceWithCommentsRendererCommentNodeRendererInteractiveEditorViewStateInteractiveEditorOptionsISerializedCellIPYNB_VIEW_TYPEIRenderPlainHtmlOutputIRenderOutputViaExtensionNotebookViewCellsSplicecellStatusIconRunningnotebookOutputContainerBorderColornotebookOutputContainerColorCELL_TOOLBAR_SEPERATORfocusedCellBackgroundselectedCellBackgroundcellHoverBackgroundselectedCellBorderinactiveSelectedCellBorderfocusedCellBorderinactiveFocusedCellBordercellStatusBarItemHoverlistScrollbarSliderBackgroundlistScrollbarSliderHoverBackgroundlistScrollbarSliderActiveBackgroundcellSymbolHighlightINotebookFindFiltersChangeEventfindFilterButtonOutputElementNotebookCellLayoutChangedEventNotebookDiffViewEventCellDiffCommonRenderTemplateNotebookMouseControllerisNotebookKeymapExtensionNotebookOutputRendererInfoStoreWorkerManagerIWorkerClientNotebookEditorModelManagerNotebookWorkerClientCellOutputElementIResizeObserverBrowserResizeObservergetResizesObservergetCodeCellExecutionContextKeyServiceICachedInsetIResolvedBackLayerWebviewIViewCellEditingDelegateJoinCellEditNotebookViewModelOptionscreateCellViewModelNOTEBOOK_BREAKPOINT_MARGIN_ACTIVEProxyKernelStateINotebookProxyKernelChangeEventEditorTopPaddingChangeEventNotebookLayoutConfigurationPerfNameNotebookOperationManagerNotebookEventEmitterCellSequenceID_NOTEBOOK_EDITOR_WORKER_SERVICEcreateProviderComparerOpenEditorContextKeyboardLayoutContributionKeyboardLayoutContributionKeyboardLayoutContributionsuiteRepeatIDropdownWithPrimaryActionViewItemOptionsSelectionKeyboardEventrunInExternalTerminalextensionResultIsMatchISuggestEnabledInputStyleOverridesIAdapterManagerDelegateCONTEXT_BREAKPOINT_ACCESS_TYPEcellInsertionIndicatorNotebookFindWidgetICssClassDelegateICellExecutionEntryIIndexedSettingISettingsTargetsWidgetOptionsISettingChangeEventSettingGroupRendererSettingNewExtensionsRendererSettingComplexRendererSettingExcludeRendererSettingEnumRendererSettingNumberRendererSettingBoolRendererONLINE_SERVICES_SETTING_TAGisExcludeSettingTOCRendererSingleLineInputHeightIDataLinkClickEventIKeybindingsEditorSearchOptionsIInternalFileMatchIDirectoryEntryIDirectoryTreeIOneSearchPathPatternISearchPathPatternICommonQueryBuilderOptionsrgErrorMsgForDisplayIFileProgressCallbackIRgGlobResultfoldersToRgExcludeGlobsfoldersToIncludeGlobsrgErrorMsgForDisplaybuildRegexParseErrorspreadGlobComponentsIRgSubmatchIRgBytesOrTextIHoverActionIEmmetActionOptionsSettingArrayRendererSettingObjectRendererSettingBoolObjectRendererSettingTextRendererSettingMultilineTextRendererpanelOpensMaximizedSettingToStringThe text was updated successfully, but these errors were encountered: