Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux Alpine builds fail when node_modules cache is warm #165135

Closed
joaomoreno opened this issue Nov 1, 2022 · 0 comments · Fixed by #165137
Closed

Linux Alpine builds fail when node_modules cache is warm #165135

joaomoreno opened this issue Nov 1, 2022 · 0 comments · Fixed by #165137
Assignees
@joaomoreno
Labels
candidate Issue identified as probable candidate for fixing in the next release insiders-released Patch has been released in VS Code Insiders vscode-build VS Code build process issues
Milestone
October 2022

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Nov 1, 2022 •
edited
Loading

Build from last Friday was ignored: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=190795&view=logs&s=c041ccde-92b7-5163-1d93-b1c06077f4b4&j=d6990164-2a6f-51e6-3bb6-255337fa6234

cc @lszomoru, @sbatten (build champs from last week)

This started happening since #163629

It only happens on full Product builds, since only those run the Alpine jobs, and whenever the node_modules cache is warm. The reason for this is due to the Pipeline Prebuild step which always runs yarn install.

cc @rebornix, @aeschli (endgame champs)
@joaomoreno joaomoreno added vscode-build VS Code build process issues candidate Issue identified as probable candidate for fixing in the next release labels Nov 1, 2022
@joaomoreno joaomoreno added this to the October 2022 milestone Nov 1, 2022
@joaomoreno joaomoreno self-assigned this Nov 1, 2022
@joaomoreno joaomoreno mentioned this issue Nov 1, 2022
Merged
joaomoreno added a commit that referenced this issue Nov 1, 2022
@joaomoreno
fix Alpine builds with npm custom registry
d07a376 
fixes #165135
joaomoreno added a commit that referenced this issue Nov 1, 2022
@joaomoreno
fix Alpine builds with npm custom registry
7706139 
fixes #165135
@joaomoreno joaomoreno mentioned this issue Nov 1, 2022
Merged
joaomoreno added a commit that referenced this issue Nov 1, 2022
@joaomoreno
Release port: fix Alpine builds with npm custom registry (#165151)
7144ff7 
fix Alpine builds with npm custom registry

fixes #165135
joaomoreno added a commit that referenced this issue Nov 1, 2022
@joaomoreno
fix Alpine builds with npm custom registry (#165137)
b0da2ea 
fixes #165135
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
candidate Issue identified as probable candidate for fixing in the next release insiders-released Patch has been released in VS Code Insiders vscode-build VS Code build process issues
Projects
None yet
Milestone
October 2022
Development

Successfully merging a pull request may close this issue.

fix Alpine builds with npm custom registry microsoft/vscode
2 participants
@joaomoreno @VSCodeTriageBot