Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notebook css variables bleed to body #165410

Closed
TylerLeonhardt opened this issue Nov 3, 2022 · 0 comments
Closed

notebook css variables bleed to body #165410

TylerLeonhardt opened this issue Nov 3, 2022 · 0 comments
Assignees
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Nov 3, 2022

I noticed that there are a couple colors here that are available in body:
image

but the rest of the colors are available in the monaco workbench div:
image

these probably should be with the others.

possible code pointer:

collector.addRule(`
:root {
--notebook-cell-status-icon-success: ${cellStatusIconSuccessColor};
--notebook-cell-status-icon-error: ${cellStatusIconErrorColor};
--notebook-cell-status-icon-running: ${cellStatusIconRunningColor};
}
`);

@TylerLeonhardt TylerLeonhardt added the debt Code quality issues label Nov 3, 2022
@rebornix rebornix added this to the November 2022 milestone Nov 3, 2022
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

No branches or pull requests

3 participants