Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment view filtering: incorrect count (Showing x of y) #165444

Closed
laurentlb opened this issue Nov 3, 2022 · 1 comment · Fixed by #165517
Closed

Comment view filtering: incorrect count (Showing x of y) #165444

laurentlb opened this issue Nov 3, 2022 · 1 comment · Fixed by #165517
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
November 2022

Comments

@laurentlb
Copy link
Contributor

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: Version: 1.73.0
  • OS Version: Windows

In some cases (I don't know when exactly), the Comment filtering widget seems to display an incorrect count. Using vscode.dev, I've made this screenshot:

image

If I change the filters, I get different results:

  • Show resolved and unresolved: Showing 7 of 4
  • Show resolved, hide unresolved: Showing 3 of 4
  • Hide resolved, show unresolved: no text
  • Hide resolved and unresolved: Showing 0 of 4

All of them seem incorrect: there are 7 comment threads.
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug and removed new release labels Nov 4, 2022
@alexr00 alexr00 added this to the November 2022 milestone Nov 4, 2022
@alexr00
Copy link
Member

alexr00 commented Nov 4, 2022

Thanks for the clear repro!

@alexr00 alexr00 mentioned this issue Nov 4, 2022
Merged
alexr00 added a commit that referenced this issue Nov 4, 2022
@alexr00
Comment view filtering: incorrect count (Showing x of y)
137d590 
Fixes #165444
alexr00 added a commit that referenced this issue Nov 4, 2022
@alexr00
Comment view filtering: incorrect count (Showing x of y) (#165517)
452e028 
Fixes #165444
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 4, 2022
@aeschli aeschli added the verified Verification succeeded label Nov 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
November 2022
Development

Successfully merging a pull request may close this issue.

Comment view filtering: incorrect count (Showing x of y) microsoft/vscode
4 participants
@laurentlb @aeschli @alexr00 @VSCodeTriageBot