Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragging an image into markdown adds the wrong path #165636

Closed
digitarald opened this issue Nov 6, 2022 · 1 comment · Fixed by #165768
Closed

Dragging an image into markdown adds the wrong path #165636

digitarald opened this issue Nov 6, 2022 · 1 comment · Fixed by #165768
Assignees
@mjbvz
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
November 2022

Comments

@digitarald
Copy link
Contributor

Type: Bug

Dragging an image from my downloads folder into a dev container notebook, I get

![Alt text](../../Users/digitarald/Downloads/so.png)

Dragging it from the VS Code Explorer into markdown I get

![Alt text](vscode-remote://dev-container%2B2f55736572732f64696769746172616c642f446576656c6f7065722f64732d64656d6f73/workspaces/ds-demos/datasets/so.png)

Not trusting the pasted results and editing it down to ![Stackoverflow Banner](datasets/so.png) works.

VS Code version: Code - Insiders 1.74.0-insider (e764c5b, 2022-11-04T05:19:54.097Z)
OS version: Darwin x64 22.1.0
Modes:
Sandboxed: No
Remote OS version: Linux x64 5.15.49-linuxkit
@mjbvz mjbvz added this to the November 2022 milestone Nov 7, 2022
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Nov 8, 2022
mjbvz added a commit to mjbvz/vscode that referenced this issue Nov 8, 2022
@mjbvz
Transform text/uri-list mime values in data transfers
3798acf 
Fixes microsoft#165636

This passes any `text/uri-list` mime values in a datatransfer through our uri transformers. Because these uri values are stored as a list of strings, they are not automatically transformed
@mjbvz mjbvz mentioned this issue Nov 8, 2022
Merged
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 10, 2022
@mjbvz mjbvz added the author-verification-requested Issues potentially verifiable by issue author label Nov 28, 2022
@VSCodeTriageBot
Copy link
Collaborator

This bug has been fixed in the latest release of VS Code Insiders!

@digitarald, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version ac084d7 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@connor4312 connor4312 added the verified Verification succeeded label Dec 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
November 2022
Development

Successfully merging a pull request may close this issue.

Transform text/uri-list mime values in data transfers mjbvz/vscode
4 participants
@digitarald @connor4312 @mjbvz @VSCodeTriageBot