Transform text/uri-list mime values in data transfers
#165768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrieken
requested changes
Nov 8, 2022
There was a problem hiding this comment.
I'd suggest to not use the uri transformer but to extract uri'ish data as URI-instances so that the conversion happens. You can use Markdown#from as inspiration for this.
mjbvz
force-pushed
the
favourable-muskox
branch
from
3798acf
to
1533efc
Compare
|
Thanks @jrieken. I switched to a different approach. Please re-review when you have a chance! |
jrieken
reviewed
Nov 10, 2022
| @@ -1966,7 +1967,7 @@ export namespace ViewBadge { | |||
| } | |||
|
|
|||
| export namespace DataTransferItem { | |||
| export function toDataTransferItem(item: extHostProtocol.DataTransferItemDTO, resolveFileData: () => Promise<Uint8Array>): types.DataTransferItem { | |||
| export function to(mime: string, item: extHostProtocol.DataTransferItemDTO, resolveFileData: () => Promise<Uint8Array>, uriTransformer?: IURITransformer): types.DataTransferItem { | |||
There was a problem hiding this comment.
there is a lone uriTransformer argument
jrieken
previously approved these changes
Nov 10, 2022
joyceerhl
approved these changes
Nov 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165636
This passes any
text/uri-listmime values in a datatransfer through our uri transformers. Because these uri values are stored as a list of strings, they are not automatically transformed