Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web: Ctrl-click on tab should open context menu but not open tab #165894

Closed
bpasero opened this issue Nov 9, 2022 · 0 comments
Closed

Web: Ctrl-click on tab should open context menu but not open tab #165894

bpasero opened this issue Nov 9, 2022 · 0 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders macos Issues with VS Code on MAC/OS X verified Verification succeeded web Issues related to running VSCode in the web
Milestone
November 2022

Comments

@bpasero
Copy link
Member

bpasero commented Nov 9, 2022 •
edited
Loading

  • open vscode for web on macOS
  • ctrl+click into a tab that is not active
  • ✅ context menu opens
  • 🐛 but also the tab opens

@sbatten fyi this is similar to #160413 and requires the same fix. Interestingly on Electron this does not seem to be an issue, maybe Ctrl+click produces context menu event in Electron but not in Web?
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug macos Issues with VS Code on MAC/OS X web Issues related to running VSCode in the web labels Nov 9, 2022
@bpasero bpasero added this to the November 2022 milestone Nov 9, 2022
@bpasero bpasero self-assigned this Nov 9, 2022
bpasero added a commit that referenced this issue Nov 9, 2022
@bpasero
Web: Ctrl-click on tab should open context menu but not open tab (fix #…
5b840e8 
…165894)
@bpasero bpasero closed this as completed in 9dabc13 Nov 9, 2022
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 9, 2022
@meganrogge meganrogge added the verified Verification succeeded label Nov 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders macos Issues with VS Code on MAC/OS X verified Verification succeeded web Issues related to running VSCode in the web
Projects
None yet
Milestone
November 2022
Development

No branches or pull requests
3 participants
@bpasero @meganrogge @VSCodeTriageBot