Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matching brackets border not functional #166109

Closed
d0ggie opened this issue Nov 11, 2022 · 1 comment · Fixed by #166141
Closed

Matching brackets border not functional #166109

d0ggie opened this issue Nov 11, 2022 · 1 comment · Fixed by #166141
Assignees
@hediet
Labels
bug Issue identified by VS Code Team member as probable bug editor-bracket-matching Editor brace matching insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
November 2022

Comments

@d0ggie
Copy link
Contributor

d0ggie commented Nov 11, 2022

Hi,

For matching brackets "editorBracketMatch.border" is no longer functional. "editorBracketMatch.background" still works.

I suspect this has been caused by commit 83b528d.

BracketMatching.css currently has border: var(--vscode-editorBracketMatch-border); but I presume this should be border: 1px solid var(--vscode-editorBracketMatch-border);

--

Does this issue occur when all extensions are disabled? Yes

Version: 1.74.0-insider (user setup)
Commit: ef41557
Date: 2022-11-11T05:19:14.666Z
Electron: 19.1.3
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Windows_NT x64 10.0.20348
Sandboxed: Yes
@hediet
Copy link
Member

hediet commented Nov 11, 2022

Thanks for reporting and investigating! It would be awesome if you could create a PR!

@hediet hediet added this to the November 2022 milestone Nov 11, 2022
@hediet hediet added bug Issue identified by VS Code Team member as probable bug editor-bracket-matching Editor brace matching labels Nov 11, 2022
d0ggie added a commit to d0ggie/vscode that referenced this issue Nov 11, 2022
@d0ggie
Restore bracket match CSS syntax (microsoft#166109)
7d0b8f1
@d0ggie d0ggie mentioned this issue Nov 11, 2022
Merged
@hediet hediet linked a pull request Nov 14, 2022 that will close this issue
Restore bracket match CSS syntax (#166109) #166141
Merged
hediet added a commit that referenced this issue Nov 14, 2022
@hediet
Merge pull request #166141 from d0ggie/bracketMatchingBorder
c9fd476 
Restore bracket match CSS syntax (#166109)
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 14, 2022
@sandy081 sandy081 added the verified Verification succeeded label Dec 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
bug Issue identified by VS Code Team member as probable bug editor-bracket-matching Editor brace matching insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
November 2022
Development

Successfully merging a pull request may close this issue.

Restore bracket match CSS syntax (#166109) d0ggie/vscode
4 participants
@hediet @sandy081 @d0ggie @VSCodeTriageBot