Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select Another Kernel shouldn't be visible if there are no other sources #166724

Closed
rebornix opened this issue Nov 18, 2022 · 1 comment
Closed

Select Another Kernel shouldn't be visible if there are no other sources #166724

rebornix opened this issue Nov 18, 2022 · 1 comment
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-kernel-picker verified Verification succeeded
Milestone
November 2022

Comments

@rebornix
Copy link
Member

When we only have a couple of notebook controllers created for a notebook type, without any kernel detection task or kernel source commands, the "Select Another Kernel" should not show.
@rebornix rebornix mentioned this issue Nov 18, 2022
Closed
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Nov 21, 2022
@rebornix rebornix added this to the November 2022 milestone Nov 23, 2022
rebornix added a commit that referenced this issue Nov 23, 2022
@rebornix
Fix #166724. Go to kernel source picker if there is no mru.
be596ef
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 23, 2022
@joyceerhl joyceerhl added the verified Verification succeeded label Dec 1, 2022
@joyceerhl
Copy link
Contributor

  1. If I have no kernels in the MRU, clicking Select Kernel brings me to this quickpick, and clicking the back button here does nothing--I think it shouldn't be shown in this scenario
    image

  2. If I have the Jupyter extension installed but not the Python extension installed, with the MRU picker enabled, the Select Kernel dropdown spins forever like this:
    image

@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-kernel-picker verified Verification succeeded
Projects
None yet
Milestone
November 2022
Development

No branches or pull requests
4 participants
@joaomoreno @rebornix @joyceerhl @VSCodeTriageBot