Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ypeError: app?.getPreferredSystemLanguages is not a function #166771

Closed
ghost opened this issue Nov 19, 2022 · 1 comment · Fixed by #166884
Closed

ypeError: app?.getPreferredSystemLanguages is not a function #166771

ghost opened this issue Nov 19, 2022 · 1 comment · Fixed by #166884
Assignees
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@ghost
Copy link

ghost commented Nov 19, 2022

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.74.0-insider 9809bdc4b70eb137a78e1204386e82f1a89d801b
  • OS Version: Fedora GNU/Linux 37

Steps to Reproduce:

  1. Run VS Code Insiders
  2. The application does not open

Ran perfectly before updating to the latest nightly build. It seems the application can't find this new Electron function:

TypeError: app?.getPreferredSystemLanguages is not a function
    at resolveNlsConfiguration (/usr/share/codium-insiders/resources/app/out/main.js:8:3212)
    at onReady (/usr/share/codium-insiders/resources/app/out/main.js:7:9760)
    at App.<anonymous> (/usr/share/codium-insiders/resources/app/out/main.js:7:9351)
    at Object.onceWrapper (node:events:646:26)
    at App.emit (node:events:526:28)

Thanks for all your hard work

@bhavyaus bhavyaus assigned rzhao271 and unassigned bhavyaus Nov 20, 2022
@rzhao271 rzhao271 added the bug Issue identified by VS Code Team member as probable bug label Nov 21, 2022
@rzhao271 rzhao271 added this to the November 2022 milestone Nov 21, 2022
rzhao271 added a commit that referenced this issue Nov 21, 2022
rzhao271 added a commit that referenced this issue Nov 21, 2022
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 21, 2022
@rzhao271 rzhao271 added the author-verification-requested Issues potentially verifiable by issue author label Nov 29, 2022
@VSCodeTriageBot
Copy link
Collaborator

This bug has been fixed in the latest release of VS Code Insiders!

@vlfldr, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version 8b98917 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@aeschli aeschli added the verified Verification succeeded label Dec 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants