Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect colors are used for \xN8 and \xN9 in strings in Rust #166781

Closed
noritada opened this issue Nov 19, 2022 · 1 comment
Closed

Incorrect colors are used for \xN8 and \xN9 in strings in Rust #166781

noritada opened this issue Nov 19, 2022 · 1 comment
Assignees
Labels
grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream

Comments

@noritada
Copy link
Contributor

noritada commented Nov 19, 2022

Type: Bug

In strings in Rust, \xN8 and \xN9 (N = 0-7) are colored incorrectly.
Although these characters are ASCII, they are colored in the same way as non-ASCII characters.

I have fixed this issue locally and will send a PR later.

ss 2022-11-19 15 53 37

Many thanks,

VS Code version: Code 1.73.1 (6261075, 2022-11-09T02:08:38.961Z)
OS version: Darwin x64 19.6.0
Modes:
Sandboxed: No

System Info
Item Value
CPUs Intel(R) Core(TM) i7-7660U CPU @ 2.50GHz (4 x 2500)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off
Load (avg) 3, 6, 5
Memory (System) 16.00GB (0.28GB free)
Process Argv . --crash-reporter-id a4a7ae6c-8e69-447d-8b0d-f4f038ddd3e6
Screen Reader no
VM 0%
Extensions: none
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627cf:30244335
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdc:30486549
c4g48928:30535728
dsvsc012:30540252
azure-dev_surveyone:30548225
vscccc:30610679
pyindex848cf:30577861
nodejswelcome1cf:30587006
fc301958:30595537
3biah626:30602489
gswce1:30612156
3d0df643:30613357
dbltrim-noruby:30604474
89544117:30613380

@noritada noritada changed the title Incorrect colors are used for \xN8 and \xN9 in binary strings in Rust Incorrect colors are used for \xN8 and \xN9 in strings in Rust Nov 19, 2022
noritada added a commit to noritada/vscode that referenced this issue Nov 19, 2022
@aeschli aeschli assigned alexr00 and unassigned aeschli Nov 21, 2022
@alexr00
Copy link
Member

alexr00 commented Nov 21, 2022

We get our Rust syntax highlighting grammar from https://github.com/dustypomerleau/rust-syntax. I've moved the issue to dustypomerleau/rust-syntax#33 and linked your PR.

@alexr00 alexr00 closed this as completed Nov 21, 2022
@alexr00 alexr00 added upstream-issue-linked This is an upstream issue that has been reported upstream grammar Syntax highlighting grammar labels Nov 21, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Development

No branches or pull requests

4 participants