Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable quick pick can not be closed using mouse / touch #167546

Closed
hediet opened this issue Nov 29, 2022 · 5 comments
Closed

Stable quick pick can not be closed using mouse / touch #167546

hediet opened this issue Nov 29, 2022 · 5 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@hediet
Copy link
Member

hediet commented Nov 29, 2022

Testing #167161

image

You need to use the keyboard (escape) to close this dialog.
This is especially problematic for tablet usage.

There are two options:

  • Close the dialog when it loses focus (like F1)
  • Show a close button in the dialog (the X)

This applies to many such dialogs, but I just noticed this while testing this feature.

@isidorn
Copy link
Contributor

isidorn commented Nov 29, 2022

As you say I think this is a general quick pick problem - when the quick pick client chooses to create a quick pick that does not hide on blur. I think quick pick currently does not support rendering the X button for closing.

In this use case using a stable quick pick is the way to go imho, so assigning to @TylerLeonhardt since he might have heard similar requests for quick pick in the past.

@isidorn isidorn assigned TylerLeonhardt and unassigned isidorn and sandy081 Nov 29, 2022
@isidorn isidorn changed the title Import Profile Dialog Cannot Be Closed With Mouse Stable quick pick can not be closed using mouse / touch Nov 29, 2022
@hediet
Copy link
Member Author

hediet commented Nov 29, 2022

What is the decision criteria of when a quick pick is stable and when not?

@isidorn
Copy link
Contributor

isidorn commented Nov 29, 2022

When you might need to alt-tab to get something, like a profile URL then it should be stable.

@gjsjohnmurray
Copy link
Contributor

Previously discussed in #99081

@TylerLeonhardt
Copy link
Member

/duplicate #99081

@VSCodeTriageBot VSCodeTriageBot added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 5, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

6 participants