nullify actionbar and view item context on dispose, remove notebook overview ruler on dispose #167817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verview ruler on dispose fixes #167813
sandy081
approved these changes
Dec 1, 2022
roblourens
reviewed
Dec 1, 2022
| @@ -2929,6 +2929,8 @@ export class NotebookEditorWidget extends Disposable implements INotebookEditorD | |||
| this._baseCellEditorOptions.forEach(v => v.dispose()); | |||
| this._baseCellEditorOptions.clear(); | |||
|
|
|||
| this._notebookOverviewRulerContainer.remove(); | |||
There was a problem hiding this comment.
Thanks for handling this! This part I don't think I follow. This is holding onto the actionbar somehow? And then the actionbar context holds onto the model?
There was a problem hiding this comment.
Yeah, I don't have a sound explanation tbh. I saw the retainer path in #167813 (comment) and decided to remove the node for good measure
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #167813