Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NotebookCellTextModel leaks when closing a notebook #167813

Closed
jrieken opened this issue Dec 1, 2022 · 0 comments · Fixed by #167817
Closed

NotebookCellTextModel leaks when closing a notebook #167813

jrieken opened this issue Dec 1, 2022 · 0 comments · Fixed by #167817
Assignees
Labels
freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues insiders-released Patch has been released in VS Code Insiders notebook
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Dec 1, 2022

  • run OSS
  • open and close .vscode/notebooks/api.github-issues (this sets the baseline)
  • take a heap snapshot in DevTool > Memory
  • open and close the notebook five more times
  • take another heap snapshot
  • show summary and filter by NotebookCellTextModel and notice each opening leaks 6 of those

I haven't fully understood the retainer path yet but it seems to stick around in some context of some ActionBar instance (which is likely also leaked). The root leakage might be something different but I guess these text models are the heavy parts

Screenshot 2022-12-01 at 09 47 35

@jrieken jrieken added freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues notebook labels Dec 1, 2022
jrieken added a commit that referenced this issue Dec 1, 2022
@jrieken jrieken added this to the November 2022 milestone Dec 1, 2022
jrieken added a commit that referenced this issue Dec 1, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues insiders-released Patch has been released in VS Code Insiders notebook
Projects
None yet
3 participants