Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt implicit activation events for notebook onRenderer #167961

Closed
Tracked by #172869
joyceerhl opened this issue Dec 2, 2022 · 0 comments
Closed
Tracked by #172869

Adopt implicit activation events for notebook onRenderer #167961

joyceerhl opened this issue Dec 2, 2022 · 0 comments
Assignees
@rebornix
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders notebook-output
Milestone
February 2023

Comments

@joyceerhl
Copy link
Contributor

Extensions which contribute notebook renderers must declare onRenderer in activationEvents, this can be inferred for extension authors by specifying the activationEventsGenerator. See also #167949

(Note, this would require adoption in the notebook renderers extension as well, which currently activates onNotebook:jupyter-notebook: https://github.com/microsoft/vscode-notebook-renderers/blob/main/package.json#L42)
@rebornix rebornix added debt Code quality issues notebook labels Dec 2, 2022
@rebornix rebornix added this to the December 2022 milestone Dec 2, 2022
@rebornix rebornix modified the milestones: January 2023, February 2023 Jan 23, 2023
@joyceerhl joyceerhl mentioned this issue Jan 30, 2023
Closed
4 tasks
rebornix added a commit that referenced this issue Jan 31, 2023
@rebornix
Fix #167961. Register implicit onRenderer activation event.
c191e30
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jan 31, 2023
@rebornix rebornix mentioned this issue Jan 31, 2023
Closed
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders notebook-output
Projects
None yet
Milestone
February 2023
Development

No branches or pull requests
3 participants
@rebornix @joyceerhl @VSCodeTriageBot