Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command navigation doesn't work as expected in task terminals #168624

Closed
Tyriar opened this issue Dec 9, 2022 · 4 comments · Fixed by #169178
Closed

Command navigation doesn't work as expected in task terminals #168624

Tyriar opened this issue Dec 9, 2022 · 4 comments · Fixed by #169178
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tasks Task system issues terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 9, 2022

Notice how for the task terminal it jumps all the way to the top on the first ctrl+up, instead of going to the most recently run task:

Recording 2022-12-09 at 08 20 53

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug tasks Task system issues terminal-shell-integration Shell integration, command decorations, etc. labels Dec 9, 2022
@Tyriar Tyriar added this to the Backlog milestone Dec 9, 2022
@Tyriar Tyriar modified the milestones: Backlog, January 2023 Dec 9, 2022
@meganrogge
Copy link
Contributor

meganrogge commented Dec 9, 2022

When I run the build task and do cmd + up, the window crashes
Screenshot 2022-12-09 at 11 32 49 AM

@Tyriar
Copy link
Member Author

Tyriar commented Dec 9, 2022

That's even worse 🤨

@meganrogge
Copy link
Contributor

the call to get markers here returns undefined

Image

@meganrogge
Copy link
Contributor

meganrogge commented Dec 14, 2022

I bet the markers are getting disposed of, so deleted from the map in bufferMarkCapability

but it looks like that wouldn't even happen since we don't set _anonymousMarkers = filtered _anonymousMarkers like we should. Could be why I see the renderer process crash?

marker.onDispose(() => this._anonymousMarkers.filter(m => m !== marker));
}

meganrogge added a commit that referenced this issue Dec 14, 2022
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 14, 2022
@Tyriar Tyriar added the verified Verification succeeded label Jan 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tasks Task system issues terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants