Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: review implicit public fields, cleanup unused exports #168927

Merged
merged 3 commits into from Jan 6, 2023

Conversation

connor4312
Copy link
Member

@connor4312 connor4312 commented Dec 12, 2022

For #166603

Also added #164935 in

@connor4312 connor4312 enabled auto-merge (squash) December 12, 2022 23:33
@connor4312 connor4312 marked this pull request as draft December 12, 2022 23:34
auto-merge was automatically disabled December 12, 2022 23:34

Pull request was converted to draft

@connor4312 connor4312 changed the title testing: review implicit public fields testing: review implicit public fields, cleanup unused exports Dec 12, 2022
@connor4312 connor4312 marked this pull request as ready for review December 12, 2022 23:51
@connor4312 connor4312 enabled auto-merge (rebase) December 12, 2022 23:51
@@ -49,18 +43,6 @@ export const testingConfiguation: IConfigurationNode = {
title: localize('testConfigurationTitle', "Testing"),
type: 'object',
properties: {
[TestingConfigKeys.AutoRunMode]: {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a setting left over from functionality which no longer exists

auto-merge was automatically disabled January 5, 2023 23:01

Rebase failed

@connor4312 connor4312 merged commit 612d2c8 into main Jan 6, 2023
@connor4312 connor4312 deleted the connor4312/166603 branch January 6, 2023 17:09
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants