debt: review implicit public fields that are actually protected

[jrieken]

Apparently TypeScript allows that a subtype to increase visibility of protected properties to public. This has become visible while working on property mangling (see #165429). This mean a subtype can prevent an inherited name from being mangled.

class Animal {
  protected legCount :number;
}

class Snail extends Animal {
  public legCount = 0; // this property is now PUBLIC, thereby Animal#legCount is also public'ish
}

To generate the list below run node build/lib/mangleTypeScript.js (note that it will create a src-mangle folder)

Generally, an inherited protected field should stay protected and while scanning over the usages I see two patterns

• accidental public-making by simply forgetting to write the keyword 👉 We should fix those
• purposeful public-making to access a protected field in tests which is 🐟y. Depending on cost and impact we should fix those

---

• setChild from src/vs/editor/common/model/bracketPairsTextModelPart/bracketPairsTree/ast.ts:264 became PUBLIC because of: src/vs/editor/common/model/bracketPairsTextModelPart/bracketPairsTree/ast.ts:391
• _postDetachModelCleanup from src/vs/editor/browser/widget/codeEditorWidget.ts:1839 became PUBLIC because of: src/vs/editor/standalone/browser/standaloneCodeEditor.ts:473
• _insertSuggestion from src/vs/editor/contrib/suggest/browser/suggestController.ts:277 became PUBLIC because of: src/vs/editor/contrib/suggest/test/browser/suggestModel.test.ts:708
• getExperiments from src/vs/workbench/contrib/experiments/common/experimentService.ts:231 became PUBLIC because of: src/vs/workbench/contrib/experiments/test/electron-browser/experimentService.test.ts:61

[bpasero]

First round: #166787

[bpasero]

Updated the list with latest.

[jrieken]

Closing this - there is one violation remaining but that made it onto the allow list

[KernelDeimos]

Closing this - there is one violation remaining but that made it onto the allow list

Aha, that explains why I didn't need to change panecomposite.ts to fix my build. That was confusing me for a little while.