Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal freeze on cd // command #169271

Closed
imblowfish opened this issue Dec 15, 2022 · 5 comments · Fixed by #170564
Closed

Terminal freeze on cd // command #169271

imblowfish opened this issue Dec 15, 2022 · 5 comments · Fixed by #170564
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member insiders-released Patch has been released in VS Code Insiders linux Issues with VS Code on Linux terminal-input Relating to typing in the terminal not doing the right thing, IMEs not working, etc. verified Verification succeeded
Milestone

Comments

@imblowfish
Copy link

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.74.1
  • OS Version: Ubuntu 22.04

Steps to Reproduce:

  1. Open integrated terminal
  2. Execute command cd //

I discovered this completely by accident when I mistyped cd ..

@imblowfish
Copy link
Author

I will also add that I'm getting the error

[UriError]: If a URI does not contain an authority component, then the path cannot begin with two slash characters ("//")

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug linux Issues with VS Code on Linux labels Jan 4, 2023
@meganrogge meganrogge added the terminal-input Relating to typing in the terminal not doing the right thing, IMEs not working, etc. label Jan 4, 2023
@meganrogge
Copy link
Contributor

Does not repro on macOS, but does on linux (WSL)

@meganrogge meganrogge added the confirmed Issue has been confirmed by VS Code Team member label Jan 4, 2023
@meganrogge
Copy link
Contributor

stack trace:

Uncaught Error: [UriError]: If a URI does not contain an authority component, then the path cannot begin with two slash characters ("//")
    at E (workbench.desktop.main.js:89:27148)
    at new c (workbench.desktop.main.js:89:28056)
    at new u (workbench.desktop.main.js:89:29437)
    at c.from (workbench.desktop.main.js:89:28854)
    at $e.computeLabel (workbench.desktop.main.js:2743:10862)
    at $e.refreshLabel (workbench.desktop.main.js:2743:9642)
    at ji.wd (workbench.desktop.main.js:2743:5211)
    at [ji.bd](http://ji.bd/) (workbench.desktop.main.js:2742:653)
    at workbench.desktop.main.js:2741:3428
    at t.EventEmitter.fire (EventEmitter.ts:55:16)
    at EventEmitter.ts:68:23
    at t.EventEmitter.fire (EventEmitter.ts:55:16)
    at E.setTitle (InputHandler.ts:2871:25)
    at t.OscHandler._handler (InputHandler.ts:292:70)
    at t.OscHandler.end (OscParser.ts:223:18)
    at t.OscParser.end (OscParser.ts:159:45)
    at c.parse (EscapeSequenceParser.ts:777:43)
    at E.parse (InputHandler.ts:485:35)
    at n._action (CoreTerminal.ts:144:99)
    at n._innerWrite (WriteBuffer.ts:164:27)
    at WriteBuffer.ts:124:29

@meganrogge
Copy link
Contributor

The issue is here. Perhaps we should just catch that?

const cwdUri = URI.from({ scheme: this._instance.workspaceFolder?.uri.scheme || Schemas.file, path: this._instance.cwd });

@Tyriar
Copy link
Member

Tyriar commented Jan 4, 2023

We could also try resolving the path:

image

Tyriar added a commit that referenced this issue Jan 4, 2023
@Tyriar Tyriar added this to the January 2023 milestone Jan 4, 2023
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 5, 2023
@mjbvz mjbvz added the verified Verification succeeded label Jan 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member insiders-released Patch has been released in VS Code Insiders linux Issues with VS Code on Linux terminal-input Relating to typing in the terminal not doing the right thing, IMEs not working, etc. verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants