Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments UI with high contrast themes. #170024

Closed
a-stewart opened this issue Dec 26, 2022 · 3 comments · Fixed by #170113
Closed

Comments UI with high contrast themes. #170024

a-stewart opened this issue Dec 26, 2022 · 3 comments · Fixed by #170113
Assignees
@alexr00
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
January 2023

Comments

@a-stewart
Copy link
Contributor

If you use a high contrast theme, there seems to be issues with the glyphs and the comment background.

image

image

Looking at the first one, it seems like it is using a "foregound" colour as the glyph background.

https://github.com/microsoft/vscode/blob/main/src/vs/workbench/contrib/comments/browser/media/review.css#L468-L471

Or it could just be that this is a hangover from before it was a glyph, but I think the default values for High Contrast themes may need updating.

I haven't yet had a chance to check on the placeholder input - apologies for not digging into this that much before posting, I'm not sure how much time I'll have today.
@a-stewart
Copy link
Contributor Author

Update, the input issue seems to be due to the default value of peekViewTitle.background being null for HC themes which means, as far as I can see, it is using the OS default button colour.

@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues comments Comments Provider/Widget/Panel issues labels Dec 27, 2022
@alexr00 alexr00 added this to the January 2023 milestone Dec 27, 2022
@alexr00 alexr00 mentioned this issue Dec 27, 2022
Merged
alexr00 added a commit that referenced this issue Dec 27, 2022
@alexr00
Comments UI with high contrast themes.
87b0883 
Fixes #170024
@alexr00
Copy link
Member

alexr00 commented Dec 27, 2022

I've made a fix for the comment gutter decoration. I wasn't able to reproduce the reply button issue though.

alexr00 added a commit that referenced this issue Dec 27, 2022
@alexr00
Comments UI with high contrast themes. (#170113)
953f7f4 
Fixes #170024
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 27, 2022
@a-stewart
Copy link
Contributor Author

I've made a fix for the comment gutter decoration. I wasn't able to reproduce the reply button issue though.

Thanks :)

@alexr00 alexr00 mentioned this issue Jan 20, 2023
Closed
@mjbvz mjbvz added the verified Verification succeeded label Jan 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
January 2023
Development

Successfully merging a pull request may close this issue.

Comments UI with high contrast themes. microsoft/vscode
4 participants
@a-stewart @mjbvz @alexr00 @VSCodeTriageBot