Fix shell integration for PowerShell 5.1 #170516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
force-pushed
the
andschwa/shell-integration
branch
from
c20ca3a
to
4e1b0e2
Compare
The pipeline operator cannot be used on a new line.
andyleejordan
force-pushed
the
andschwa/shell-integration
branch
from
4e1b0e2
to
6313d41
Compare
Tyriar
approved these changes
Jan 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pipeline operator cannot be used on a new line, which caused #167068.
Also sets the dubious runtime "strict mode" PowerShell feature off in the
promptfunction. Note that this is off by default, but can be turned on by users, leading to cryptic issues as this code expects$LastHistoryEntry.Idto just be return$Nullwhen$LastHistoryEntryis$Null(a reasonable expectation and valid PowerShell code, just against "strict" mode's guidelines). This caused PowerShell/vscode-powershell#4343.Image of it working again: