Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shell integration for PowerShell 5.1 #170516

Merged
merged 2 commits into from
Jan 12, 2023
+4 −2
Merged

Fix shell integration for PowerShell 5.1 #170516

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5842ab4
Fix syntax for PowerShell 5.1
andyleejordan Jan 3, 2023
6313d41
Disable PowerShell strict mode in shell integration's prompt function
andyleejordan Jan 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/vs/workbench/contrib/terminal/browser/media/shellIntegration.ps1
View file
Open in desktop
Expand Up @@ -23,13 +23,15 @@ function Global:__VSCode-Escape-Value([string]$value) {
[regex]::Replace($value, '[\\\n;]', { param($match)
# Encode the (ascii) matches as `\x<hex>`
-Join (
[System.Text.Encoding]::UTF8.GetBytes($match.Value)
| ForEach-Object { '\x{0:x2}' -f $_ }
[System.Text.Encoding]::UTF8.GetBytes($match.Value) | ForEach-Object { '\x{0:x2}' -f $_ }
)
})
}

function Global:Prompt() {
# NOTE: We disable strict mode for the scope of this function because it unhelpfully throws an
# error when $LastHistoryEntry is null, and is not otherwise useful.
Set-StrictMode -Off
$FakeCode = [int]!$global:?
$LastHistoryEntry = Get-History -Count 1
# Skip finishing the command if the first command has not yet started
Expand Down