Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider the open symbol keybinding as the default keybinding for Terminal: open detected link #170643

Closed
Tyriar opened this issue Jan 5, 2023 · 1 comment · Fixed by #170696
Closed

Consider the open symbol keybinding as the default keybinding for Terminal: open detected link #170643

Tyriar opened this issue Jan 5, 2023 · 1 comment · Fixed by #170696
Assignees
@Tyriar @meganrogge
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-links verification-needed Verification of issue is requested verified Verification succeeded
Milestone
January 2023

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 5, 2023

It's similar functionality to symbol search and probably won't conflict with shell hotkeys
@Tyriar Tyriar added feature-request Request for new features or functionality accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues terminal-links labels Jan 5, 2023
@Tyriar Tyriar added this to the January 2023 milestone Jan 5, 2023
Tyriar added a commit that referenced this issue Jan 6, 2023
@Tyriar
Ctrl/cmd+shift+o to open detected link in the terminal
4b4597e 
This is similar functionality to go to symbol in the editor.

Fixes #170643
@Tyriar Tyriar mentioned this issue Jan 6, 2023
Merged
Tyriar added a commit to microsoft/vscode-docs that referenced this issue Jan 6, 2023
@Tyriar
Add new open detected link keybinding
de1037c 
Part of microsoft/vscode#170643
@Tyriar Tyriar mentioned this issue Jan 6, 2023
Merged
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jan 6, 2023
gregvanl pushed a commit to microsoft/vscode-docs that referenced this issue Jan 6, 2023
@Tyriar
Add new open detected link keybinding (#5922)
94d6965 
* Add new open detected link keybinding

Part of microsoft/vscode#170643

* formatting

Co-authored-by: Greg Van Liew <gregvanl@microsoft.com>
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 9, 2023
@Tyriar
Copy link
Member Author

Tyriar commented Jan 23, 2023

To verify, ensure ctrl/cmd+shift+o triggers the open detected link command

@Tyriar Tyriar added the verification-needed Verification of issue is requested label Jan 23, 2023
@alexr00 alexr00 added the verified Verification succeeded label Jan 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-links verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
January 2023
Development

Successfully merging a pull request may close this issue.

Ctrl/cmd+shift+o to open detected link in the terminal microsoft/vscode
4 participants
@Tyriar @meganrogge @alexr00 @VSCodeTriageBot