Adapt the bash of busybox.

[fxzxmic]

• VSCode Version: 1.74.2
• Local OS Version: Windows 11 Build 22621
• Remote OS Version: Alpine Linux v3.17
• Remote Extension/Connection Type: WSL

• Logs:

Steps to Reproduce:

1. Start a terminal.
2. 

I use busybox bash as /bin/bash (still busybox ash in essence), which is why there is no .bashrc.
I hope vs code server can judge whether it is a real bash before using it, if not, treat the bash as ash.

Does this issue occur when you try this locally?: No
Does this issue occur when you try this locally and all extensions are disabled?: No

[fxzxmic]

In fact, busybox bash/ash does not support the builtin command. I've found the way to set /bin/ash as the default shell of vscode instead of the automatically detected /bin/bash, so I don't know if this problem still needs to be fixed.

[Tyriar]

Thanks, it's still an issue then. We should detect if it's busybox either before injecting the shell integration or at the start of the script.

[meganrogge]

I'll create another issue for the case when there's no .bashrc file so that gets verified

[fxzxmic]

Check whether $BASH_VERSION exists? This is probably the easiest way.

When I delete the code for reading .bashrc and the builtin command, it still reports an error.


It seems that busybox bash/ash is not compatible with this script.

Perhaps there could be an injection script for busybox bash/ash?

[Tyriar]

This is available for contributions. I believe all this needs is an if here to exit early if it is busybox:

vscode/src/vs/workbench/contrib/terminal/browser/media/shellIntegration-bash.sh

Lines 6 to 9 in d70a46b

	# Prevent the script recursing when setting up
	if [[ -n "${VSCODE_SHELL_INTEGRATION:-}" ]]; then
	builtin return
	fi

It needs to be tested of course and be a low risk change for regular bash.

[fxzxmic]

Perhaps we should exit the script when we detect that this is not a true bash, or only perform some necessary injections. Otherwise, it would be too complicated to fully adapt to Busybox's bash.