ANSI OSC 8 hyperlink support NOT working properly (#155445)

[smallscript]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.74.2
• OS Version: Windows 10

In reference to Support OSC 8 hyperlink support #155445.

Per this gist spec it works properly in wt.exe but not in VsCode.

    # OSC 8 ; params ; URI ST <name> OSC 8 ;; ST 
    escape_mask = '\033]8;{};{}\033\\{}\033]8;;\033\\'

After about 6 hours of experimentation (in various MS-Windows based terminals) to understand why it was not working, I figured out the bug in VsCode.

In the example steps below I provide two forms

• a first (incorrect) form works in wt.exe and also sort-of works in VsCode.
• a second (per-gist correct) form works in wt.exe but does not work in VsCode.
  • where we introduce a SPACE in the closing OSC ; ;.

The example shows the trigger/change to make it sort-of work in VsCode.

You will notice that when made to sort-of work in VsCode the ENTIRE line from start to end including the prompt becomes the link, which is wrong. It is a very quirky and touchy bug behavior.

Steps to Reproduce: (these steps worked 100%, other variations required pre-conditions)

1. If we introduce a SPACE in the closing OSC ; ; we can get VsCode to work (incorrectly) as opposed to not-at-all.

# VsCode WORKS: (incorrectly) includes ENTIRE LINE and PROMPT as LINK
# i.e., VsCode acts like `[BEFORE-LINK ctrl-click-here AFTER-LINK](http://example.com)`
# should act like `BEFORE-LINK [ctrl-click-here\n](http://example.com) AFTER-LINK`
#
# wt.exe WORKS
# wt.exe acts like `BEFORE-LINK [ctrl-click-here\n](http://example.com) AFTER-LINK`
works_vsc = 'BEFORE-LINK \x1B]8;;http://example.com\x1B\\ctrl-click-here\x1B]8; ;\x1B\\ AFTER-LINK'

# VsCode FAILS: in this correct format, which works with no issues in wt.exe
#
# wt.exe WORKS
# i.e., wt.exe acts like `BEFORE-LINK [ctrl-click-here](http://example.com) AFTER-LINK`
fails_vsc 'BEFORE-LINK \x1B]8;;http://example.com\x1B\\ctrl-click-here\x1B]8;;\x1B\\ AFTER-LINK'

print(works_vsc)
print(fails_vsc)

[Tyriar]

Upstream: xtermjs/xterm.js#4916

[smallscript]

I'm using Windows 10 Pro latest build, same for VsCode. As cited in the bug, wt.exe works properly, but code.exe console in each of its variants does not.It might be perhaps  notable that for both wt.exe and code.exe embedded consoles all variants, I'm using CMD.exe shell as powershell has special console integration that makes it unsuitable as a sole test case.I can produce YouTube video and/environment captures of system setup as required.Thank you!DavidOn Feb 28, 2024 2:44 PM, "Marcos H. Valdez III" ***@***.***> wrote: I was going to request this be assigned to me but I can't duplicate it. VS Code 1.87 Windows 11 Pro (Version 10.0.22631 Build 22631) All extensions disabled Running the provided code from the VS Code PowerShell terminal results in the correct behavior from both works_vc AND fails_vc (if you add a '=' between fails_vsc and the string). —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>

[Tyriar]

Upstream fix: xtermjs/xterm.js#5027

[smallscript]

Looking forward to that Tyriar. If the cls back-buffer behavior also worked like wt.exe it would be the best day all year.
🙇🏻‍♂️

[rzhao271]

With pwsh and cmd on Windows Terminal, it seems to me that only the http://example.com portion is underlined.
On VS Code, http://example.com\x1B\\ctrl-click-here\x1B is underlined.
I'd like to check whether either behaviour is as expected for you, @smallscript?

[VSCodeTriageBot]

This bug has been fixed in the latest release of VS Code Insiders!

@smallscript, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version 6d23b7f of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

[smallscript]

It's a bit more involved. the OSC-8 feature has worked for a long time on win10 and Win11 with wt.exe.The xterm.js in VsCode supports OSC-8 properly on Windows 11, but on Windows 10 it just shows the label text but it is not a clickable link. For reference, that's the case with the latest version of VsCode (same version on win10 and win11) using the latest releases/updates to patch Tuesday win10 PRO and win 11 PRO.I'm guessing it's an electron issue in relation to Windows ConPTY.On Apr 24, 2024 1:07 PM, Raymond Zhao ***@***.***> wrote: With pwsh and cmd on Windows Terminal, it seems to me that only the http://example.com portion is underlined. On VS Code, http://example.com\x1B\\ctrl-click-here\x1B is underlined. I'd like to check whether either behaviour is as expected for you, @smallscript? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

[smallscript]

I should also add, it's the same kind of issue with flushing the back buffer when using the "CLS" cmd not clearing the back buffer on Windows 10.On Apr 24, 2024 4:39 PM, ***@***.*** wrote:It's a bit more involved. the OSC-8 feature has worked for a long time on win10 and Win11 with wt.exe.The xterm.js in VsCode supports OSC-8 properly on Windows 11, but on Windows 10 it just shows the label text but it is not a clickable link. For reference, that's the case with the latest version of VsCode (same version on win10 and win11) using the latest releases/updates to patch Tuesday win10 PRO and win 11 PRO.I'm guessing it's an electron issue in relation to Windows ConPTY.On Apr 24, 2024 1:07 PM, Raymond Zhao ***@***.***> wrote: With pwsh and cmd on Windows Terminal, it seems to me that only the http://example.com portion is underlined. On VS Code, http://example.com\x1B\\ctrl-click-here\x1B is underlined. I'd like to check whether either behaviour is as expected for you, @smallscript? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

[rzhao271]

I'll clarify my question. Has your original issue, #170963 (comment), been resolved on VS Code Insiders? You can get a copy of VS Code Insiders from https://code.visualstudio.com/insiders/.

As for the back buffer issue, feel free to open a new issue in this repository.

[smallscript]

apologies for misunderstanding. I'll check that today. FYI, my time zone is Hawaii so it will be late today. Mahalo,DavidOn Apr 25, 2024 7:26 AM, Raymond Zhao ***@***.***> wrote: I'll clarify my question. Has your original issue, #170963 (comment), been resolved on VS Code Insiders? You can get a copy of VS Code Insiders from https://code.visualstudio.com/insiders/. As for the back buffer issue, feel free to open a new issue in this repository. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

[Tyriar]

Verified:

[smallscript]

I've now been able to test with that version.Whatever the issue is on Windows 10, that did not resolve it. I'm happy to dig deeper, but I world need a little advice on what logs to look at. Mahalo,DavidOn Apr 25, 2024 9:30 AM, ***@***.*** wrote:apologies for misunderstanding. I'll check that today. FYI, my time zone is Hawaii so it will be late today. Mahalo,DavidOn Apr 25, 2024 7:26 AM, Raymond Zhao ***@***.***> wrote: I'll clarify my question. Has your original issue, #170963 (comment), been resolved on VS Code Insiders? You can get a copy of VS Code Insiders from https://code.visualstudio.com/insiders/. As for the back buffer issue, feel free to open a new issue in this repository. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

[Tyriar]

@smallscript it's likely a Windows 10 problem caused by conpty which is shipped by Windows then. Unfortunately the fix there is to upgrade to Windows 11 which has the newer component.