Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code OSS rpm builds state official build license #17133

Closed
Tyriar opened this issue Dec 13, 2016 · 0 comments · Fixed by #17151
Closed

Code OSS rpm builds state official build license #17133

Tyriar opened this issue Dec 13, 2016 · 0 comments · Fixed by #17151
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug install-update VS Code installation and upgrade system issues linux Issues with VS Code on Linux polish Cleanup and polish issue verified Verification succeeded
Milestone
January 2017

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 13, 2016

https://github.com/Microsoft/vscode/blob/master/resources/linux/rpm/code.spec.template#L8

It should be derived from product.json.
@Tyriar Tyriar added install-update VS Code installation and upgrade system issues linux Issues with VS Code on Linux polish Cleanup and polish issue labels Dec 13, 2016
@Tyriar Tyriar added this to the January 2017 milestone Dec 13, 2016
@Tyriar Tyriar self-assigned this Dec 13, 2016
@Tyriar Tyriar mentioned this issue Dec 13, 2016
Merged
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Dec 14, 2016
Tyriar added a commit that referenced this issue Dec 14, 2016
@Tyriar
Use license in product.json for rpm
b69e40d 
Fixes #17133
@Tyriar Tyriar mentioned this issue Dec 14, 2016
Merged
@Tyriar Tyriar added the verified Verification succeeded label Jan 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@Tyriar
Use license in product.json for rpm
c407db8 
Fixes microsoft#17133
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug install-update VS Code installation and upgrade system issues linux Issues with VS Code on Linux polish Cleanup and polish issue verified Verification succeeded
Projects
None yet
Milestone
January 2017
Development

Successfully merging a pull request may close this issue.

Use license in product.json for rpm microsoft/vscode
1 participant
@Tyriar