Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong strings and missing icon in activity bar #171834

Closed
bwateratmsft opened this issue Jan 20, 2023 · 22 comments
Closed

Wrong strings and missing icon in activity bar #171834

bwateratmsft opened this issue Jan 20, 2023 · 22 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@bwateratmsft
Copy link
Contributor

Filed based on microsoft/vscode-docker#3783 (comment) from @Bananas-Are-Yellow

The user has installed the Docker extension, and on version 1.23.3, none of the strings show up correctly--instead displaying their placeholder IDs for indexing into package.nls.json--and the icon in the activity bar is blank. Installing 1.22.2 fixes it, but uninstalling and reinstalling 1.23.3 does not. This is the only user we're aware of that is affected by this issue.

image

@bwateratmsft
Copy link
Contributor Author

Seems similar to #159485.

@TylerLeonhardt
Copy link
Member

@bwateratmsft @Bananas-Are-Yellow was there any error in the dev tools (>Developer: Toggle Developer Tools) when you saw this?

Maybe something in the Window Shared or Main Output windows (ctrl+shift+o I think on Windows?)

@TylerLeonhardt TylerLeonhardt added the info-needed Issue requires more information from poster label Feb 1, 2023
@Bananas-Are-Yellow
Copy link

In the first section where it says %VSCODE-DOCKER.VIEWS,DOCKERCONTAINERS%, I pressed the Refresh icon that appears when I move the mouse over that heading. In the Dev Tools console output, I got this:

image

Likewise if I refresh any of the other sections.

@Bananas-Are-Yellow
Copy link

The problem has gone away for me now. See microsoft/vscode-docker#3783 (comment) for details.

@TylerLeonhardt
Copy link
Member

Odd... well if you do see it again, I'd love to know more! Closing this since the repro is gone.

@bwateratmsft
Copy link
Contributor Author

Looks like this hit another user: microsoft/vscode-docker#3853

/cc @matteo-bombelli

@matteo-bombelli
Copy link

matteo-bombelli commented Mar 8, 2023

Looks like this hit another user: microsoft/vscode-docker#3853

/cc @matteo-bombelli

an update:

  • reinstalling the plugin with version v1.24.0 does not solve the issue. (issues only on wsl)
  • downgrading it to v1.23.3 does solve the issue

I hope this detail could help for future releases.

@TylerLeonhardt TylerLeonhardt reopened this Mar 9, 2023
@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Mar 9, 2023

@matteo-bombelli

issues only on wsl

can you elaborate more on this?

@matteo-bombelli
Copy link

matteo-bombelli commented Mar 14, 2023

i have ubuntu and debian installed on windows using wsl (windows subsystem for linux). if I use this extension with workspaces on windows I have no issues, instead if I use it with the one that are on the linux subsystem (both ubuntu and debian) I get the issue described here. If I degrade the version to the old one I get no issue on windows but also no issue on wsl linux.

Thank you!

more details here

microsoft/vscode-docker#3853 (comment)

@TylerLeonhardt
Copy link
Member

@matteo-bombelli when opening the WSL workspaces, are you using the WSL extension?

@matteo-bombelli
Copy link

yes I'm using the extension

@TylerLeonhardt
Copy link
Member

@matteo-bombelli can you share the full recursive directory of the docker extension underneath ~/.vscode-server/extensions/? The directory should be ms-azuretools.vscode-docker-1.24.0

@matteo-bombelli
Copy link

@TylerLeonhardt on windows or wsl?

@TylerLeonhardt
Copy link
Member

WSL

@matteo-bombelli
Copy link

matteo-bombelli commented Mar 17, 2023

on wsl

/home/matteo/.vscode-server/extensions/ms-azuretools.vscode-docker-1.23.3/

@matteo-bombelli
Copy link

on wsl

/home/matteo/.vscode-server/extensions/ms-azuretools.vscode-docker-1.23.3/

just a note, now I downgraded ... It was 1.24 when the problem was showing.... sorry for the confusion

@TylerLeonhardt
Copy link
Member

Can you run tree on the good directory and bad directory?

I'd love to compare their file structure

@matteo-bombelli
Copy link

matteo-bombelli commented Mar 18, 2023

matteo@MSI:~/.vscode-server/extensions/ms-azuretools.vscode-docker-1.23.3$ tree
.
├── CHANGELOG.md
├── LICENSE.md
├── NOTICE.html
├── README.md
├── SECURITY.md
├── dist
│   ├── 164.js
│   ├── 488.js
│   ├── 939.js
│   ├── 939.js.LICENSE.txt
│   ├── compose-language-service
│   │   └── lib
│   │       ├── server.js
│   │       └── server.js.LICENSE.txt
│   ├── dockerfile-language-server-nodejs
│   │   └── lib
│   │       └── server.js
│   ├── extension.bundle.js
│   ├── extension.bundle.js.LICENSE.txt
│   └── node_modules
│       ├── @microsoft
│       │   └── vscode-azext-azureutils
│       │       └── resources
│       │           ├── azure.svg
│       │           └── azureSubscription.svg
│       └── open
│           └── xdg-open
├── main.js
├── package.json
├── package.nls.json
└── resources
    ├── azureRegistry.svg
    ├── dark
    │   └── docker.svg
    ├── docker.svg
    ├── docker_blue.png
    ├── gitlab.svg
    ├── light
    │   └── docker.svg
    ├── netCore
    │   ├── GetBlazorManifestLocations.targets
    │   ├── GetProjectProperties.targets
    │   └── vsdbg
    ├── python
    │   └── launcher.py
    ├── templates
    │   ├── cpp
    │   │   └── Dockerfile.template
    │   ├── docker-compose.debug.yml.template
    │   ├── docker-compose.yml.template
    │   ├── go
    │   │   └── Dockerfile.template
    │   ├── java
    │   │   ├── Dockerfile.template
    │   │   └── docker-compose.debug.yml.template
    │   ├── netCore
    │   │   ├── Dockerfile.template
    │   │   ├── docker-compose.debug.yml.template
    │   │   └── docker-compose.yml.template
    │   ├── node
    │   │   ├── Dockerfile.template
    │   │   ├── docker-compose.debug.yml.template
    │   │   └── docker-compose.yml.template
    │   ├── other
    │   │   └── Dockerfile.template
    │   ├── python
    │   │   ├── Dockerfile.template
    │   │   ├── docker-compose.debug.yml.template
    │   │   ├── docker-compose.yml.template
    │   │   └── requirements.txt.template
    │   └── ruby
    │       └── Dockerfile.template
    └── walkthroughs
        └── empty.md
matteo@MSI:~/.vscode-server/extensions/ms-azuretools.vscode-docker-1.24.0$ tree
.
├── CHANGELOG.md
├── LICENSE.md
├── NOTICE.html
├── README.md
├── SECURITY.md
├── dist
│   ├── 164.js
│   ├── 488.js
│   ├── 939.js
│   ├── 939.js.LICENSE.txt
│   ├── compose-language-service
│   │   └── lib
│   │       ├── server.js
│   │       └── server.js.LICENSE.txt
│   ├── dockerfile-language-server-nodejs
│   │   └── lib
│   │       └── server.js
│   ├── extension.bundle.js
│   ├── extension.bundle.js.LICENSE.txt
│   └── node_modules
│       ├── @microsoft
│       │   └── vscode-azext-azureutils
│       │       └── resources
│       │           ├── azure.svg
│       │           └── azureSubscription.svg
│       └── open
│           └── xdg-open
├── main.js
├── package.json
├── package.nls.json
└── resources
    ├── azureRegistry.svg
    ├── dark
    │   └── docker.svg
    ├── docker.svg
    ├── docker_blue.png
    ├── gitlab.svg
    ├── light
    │   └── docker.svg
    ├── netCore
    │   ├── GetBlazorManifestLocations.targets
    │   ├── GetProjectProperties.targets
    │   └── vsdbg
    ├── python
    │   └── launcher.py
    ├── templates
    │   ├── cpp
    │   │   └── Dockerfile.template
    │   ├── docker-compose.debug.yml.template
    │   ├── docker-compose.yml.template
    │   ├── go
    │   │   └── Dockerfile.template
    │   ├── java
    │   │   ├── Dockerfile.template
    │   │   └── docker-compose.debug.yml.template
    │   ├── netCore
    │   │   ├── Dockerfile.template
    │   │   ├── docker-compose.debug.yml.template
    │   │   └── docker-compose.yml.template
    │   ├── node
    │   │   ├── Dockerfile.template
    │   │   ├── docker-compose.debug.yml.template
    │   │   └── docker-compose.yml.template
    │   ├── other
    │   │   └── Dockerfile.template
    │   ├── python
    │   │   ├── Dockerfile.template
    │   │   ├── docker-compose.debug.yml.template
    │   │   ├── docker-compose.yml.template
    │   │   └── requirements.txt.template
    │   └── ruby
    │       └── Dockerfile.template
    └── walkthroughs
        └── empty.md

25 directories, 49 files

@matteo-bombelli
Copy link

now it works even 1.24.0 🤨

@TylerLeonhardt
Copy link
Member

The bug realized we were on to it, so it decided to hide. @matteo-bombelli are you using VS Code stable or insiders?

@matteo-bombelli
Copy link

The bug realized we were on to it, so it decided to hide. @matteo-bombelli are you using VS Code stable or insiders?

stable

@TylerLeonhardt
Copy link
Member

Ok sounds good. We did have a few smaller fixes in the translation stuff this past month so this might go away... in any case, since we don't have a repro anymore, I'll close this.

When this does happen to someone again, I would love the contents of the Shared output channel... and maybe the contents of Dev Tools (Toggle Developer Tools in Command Palette) as well

@TylerLeonhardt TylerLeonhardt closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

8 participants
@TylerLeonhardt @hediet @Bananas-Are-Yellow @chrmarti @matteo-bombelli @bwateratmsft @VSCodeTriageBot and others