"Revert Selected Ranges" not working- m.getChanges is not a function

[roblourens]

• Open https://github.com/microsoft/vscode/blob/3d2e10fa6ee6c30cbc72647dff512bf16cc94403/src/vs/workbench/contrib/notebook/browser/notebook.contribution.ts
• Do "organize imports"
• Select all the imports and run "Revert Selected Ranges"

2023-01-20 13:32:25.877 [error] TypeError: m.getChanges is not a function
    at cc.$getDiffInformation (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2301:14870)
    at m.N (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1573:15147)
    at m.M (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1573:14865)
    at m.H (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1573:13958)
    at m.G (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1573:12939)
    at vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1573:11727
    at p.invoke (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:86:145)
    at n.deliver (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:86:2029)
    at a.fire (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:86:1667)
    at r.fire (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:553:15221)
    at q.onmessage (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1671:1489) git.revertSelectedRanges {"value":"vscode.git","c":"vscode.git"}

[DFelten]

I think on mac there is the same problem. When I try to revert a change within a file, there is a git error. But the git output is empty (or at least nothing new appears after trying to revert a change).

[lszomoru]

@alexr00, it looks like this is a regression that was introduced with this commit.
In that commit the getChanges() method has been removed which unfortunately is used here:

vscode/src/vs/workbench/api/browser/mainThreadEditors.ts

Lines 271 to 272 in 1278cb5

	return Promise.resolve((dirtyDiffContribution as any).getChanges());
	}

I do not have full contact on why the as any cast is being used here. @joaomoreno do you have any context?

[lszomoru]

I have investigated some other issues and it looks like that commit might have a broader impact as the stage/revert changes commands also seem to be broken. The root cause is that the vscode.git extension is expecting LineChange[] while it gets LabeledChange[]. Let's get together first thing tomorrow morning to get to the bottom of this. Thanks!

[lszomoru]

Thank you very much @alexr00 🎉

[kamenminkov]

That was fixed so quickly that I didn't have time to complain :D
Thank you!