Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use toLocaleString for the Settings editor #171881

Merged
merged 1 commit into from Jan 20, 2023
Merged

Don't use toLocaleString for the Settings editor #171881

merged 1 commit into from Jan 20, 2023

Conversation

rzhao271
Copy link
Contributor

Fixes #171787

Using toLocaleString results in the numeric string containing extra characters such as commas, which the numeric inputBox doesn't understand.

@rzhao271 rzhao271 self-assigned this Jan 20, 2023
@rzhao271 rzhao271 enabled auto-merge (squash) January 20, 2023 22:00
@VSCodeTriageBot VSCodeTriageBot added this to the January 2023 milestone Jan 20, 2023
@rzhao271 rzhao271 merged commit 8518810 into main Jan 20, 2023
@rzhao271 rzhao271 deleted the rzhao271/se-numlocale-fix branch January 20, 2023 22:20
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meganrogge meganrogge meganrogge approved these changes

Assignees

@rzhao271 rzhao271

Labels
None yet
Projects
None yet
Milestone
January 2023
Development

Successfully merging this pull request may close these issues.

Terminal setting has invalid default
3 participants
@rzhao271 @meganrogge @VSCodeTriageBot