[Accessibility] Ctrl+M (editor.action.toggleTabFocusMode) does not work inside terminal input field

[jooyoungseo]

CC @meganrogge

Reproducible Steps

1. Load screen reader.

2. Open terminal.

3. Focus in terminal input area.

4. Press Ctrl+M to toggle tab-key move (editor.action.toggleTabFocusMode).

• Notes: I don't hear any change. It does not seem to work.

Expected Behavior

Pressing Ctrl+M key needs to toggle the tab-key move mode.

System Info

Version: 1.75.0-insider (system setup)
Commit: f1b0923
Date: 2023-01-23T11:53:59.088Z
Electron: 19.1.9
Chromium: 102.0.5005.194
Node.js: 16.14.2
V8: 10.2.154.23-electron.0
OS: Windows_NT x64 10.0.22621
Sandboxed: Yes

[meganrogge]

Yep does not work on windows

[meganrogge]

the logs show that the keybinding works and Invoking command editor.action.toggleTabFocusMode. but then it doesn't happen

2023-01-25 06:25:58.152 [info] [KeybindingService]: / Received  keydown event - modifiers: [ctrl], code: ControlLeft, keyCode: 17, key: Control
2023-01-25 06:25:58.152 [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl], code: ControlLeft, keyCode: 5 ('Ctrl')
2023-01-25 06:25:58.153 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2023-01-25 06:25:58.301 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-01-25 06:25:58.302 [info] [KeybindingService]: | Resolving ctrl+M
2023-01-25 06:25:58.304 [info] [KeybindingService]: \ From 1 keybinding entries, matched editor.action.toggleTabFocusMode, when: no when condition, source: built-in.
2023-01-25 06:25:58.306 [info] [KeybindingService]: / Received  keydown event - modifiers: [ctrl], code: KeyM, keyCode: 77, key: m
2023-01-25 06:25:58.306 [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl], code: KeyM, keyCode: 43 ('M')
2023-01-25 06:25:58.307 [info] [KeybindingService]: | Resolving ctrl+M
2023-01-25 06:25:58.307 [info] [KeybindingService]: \ From 1 keybinding entries, matched editor.action.toggleTabFocusMode, when: no when condition, source: built-in.
2023-01-25 06:25:58.308 [info] [KeybindingService]: + Invoking command editor.action.toggleTabFocusMode.
2023-01-25 06:25:58.447 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-01-25 06:25:58.448 [info] [KeybindingService]: | Resolving ctrl+M
2023-01-25 06:25:58.449 [info] [KeybindingService]: \ From 1 keybinding entries, matched editor.action.toggleTabFocusMode, when: no when condition, source: built-in.

[meganrogge]

it only gets run when there's an editor view model, which there isn't when the terminal is focused

vscode/src/vs/editor/browser/coreCommands.ts

Lines 34 to 46 in fc5d2e8

	export abstract class CoreEditorCommand<T> extends EditorCommand {
	public runEditorCommand(accessor: ServicesAccessor | null, editor: ICodeEditor, args?: Partial<T> | null): void {
	const viewModel = editor._getViewModel();
	if (!viewModel) {
	// the editor has no view => has no cursors
	return;
	}
	this.runCoreEditorCommand(viewModel, args || {});
	}
	public abstract runCoreEditorCommand(viewModel: IViewModel, args: Partial<T>): void;
	}