Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export profile confirmation dialog should be an info dialog #172158

Closed
aeschli opened this issue Jan 24, 2023 · 2 comments
Closed

Export profile confirmation dialog should be an info dialog #172158

aeschli opened this issue Jan 24, 2023 · 2 comments
Assignees
@bpasero
Labels
dialogs Issues with native and custom dialogs insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
January 2023

Comments

@aeschli
Copy link
Contributor

aeschli commented Jan 24, 2023 •
edited

Testing #172034

Version: 1.75.0-insider
Commit: 0a6c277
Date: 2023-01-24T05:22:50.699Z
Electron: 19.1.9
Chromium: 102.0.5005.194
Node.js: 16.14.2
V8: 10.2.154.23-electron.0
OS: Linux x64 5.15.0-56-generic
Sandboxed: Yes

  • Export a profile to a file
  • Confirmation dialog shows a question mark, but there's no question here

image
@aeschli
Copy link
Contributor Author

aeschli commented Jan 24, 2023

It's better on Windows:
image

@sandy081 sandy081 assigned bpasero and unassigned sandy081 Jan 24, 2023
bpasero added a commit that referenced this issue Jan 25, 2023
@bpasero
Export profile confirmation dialog should be an info dialog (fix #172158
66a6393 
)
@bpasero bpasero added this to the January 2023 milestone Jan 25, 2023
@bpasero bpasero added verification-needed Verification of issue is requested dialogs Issues with native and custom dialogs labels Jan 25, 2023
@bpasero
Copy link
Member

bpasero commented Jan 25, 2023

We can change all dialogs from IDialogService.show to use info instead of question type. This only seems to have an impact on Linux and changes the icon to an info icon.

@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jan 25, 2023
@bhavyaus bhavyaus added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Jan 25, 2023
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
dialogs Issues with native and custom dialogs insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
January 2023
Development

No branches or pull requests
5 participants
@bpasero @aeschli @sandy081 @bhavyaus @VSCodeTriageBot