Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WSL mnt link is case sensitive #172225

Closed
joyceerhl opened this issue Jan 24, 2023 · 1 comment · Fixed by #173378
Closed

WSL mnt link is case sensitive #172225

joyceerhl opened this issue Jan 24, 2023 · 1 comment · Fixed by #173378
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-links verified Verification succeeded WSL Issue when using WSL
Milestone
February 2023

Comments

@joyceerhl
Copy link
Contributor

Testing #172084

image

Maybe this is expected behavior, but in the above screenshot, the first output link results in this error:

image

while the second output link correctly resolves the target file.
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-links labels Jan 24, 2023
@Tyriar Tyriar added this to the February 2023 milestone Jan 24, 2023
@Tyriar
Copy link
Member

Tyriar commented Feb 3, 2023 •
edited

While somewhat unexpected, it looks like the wslpath tool doesn't respect an upper case drive letter there which is why it fails:

image

So I'll keep it as not resolving the capital letter as the official tool doesn't convert it. Will push a fix to support errors from wslpath though

@Tyriar Tyriar added the WSL Issue when using WSL label Feb 3, 2023
Tyriar added a commit that referenced this issue Feb 3, 2023
@Tyriar
Return original path when wslpath fails
da84420 
Fixes #172225
@Tyriar Tyriar mentioned this issue Feb 3, 2023
Merged
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 3, 2023
c-claeys pushed a commit to c-claeys/vscode that referenced this issue Feb 16, 2023
@Tyriar @c-claeys
Return original path when wslpath fails
cd30120 
Fixes microsoft#172225
@joyceerhl joyceerhl added the verified Verification succeeded label Feb 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-links verified Verification succeeded WSL Issue when using WSL
Projects
None yet
Milestone
February 2023
Development

Successfully merging a pull request may close this issue.

Return original path when wslpath fails microsoft/vscode
3 participants
@Tyriar @joyceerhl @VSCodeTriageBot