Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cell appears running after cancelling kernel selection #172244

Closed
amunger opened this issue Jan 24, 2023 · 2 comments
Closed

Cell appears running after cancelling kernel selection #172244

amunger opened this issue Jan 24, 2023 · 2 comments
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-kernel-picker verified Verification succeeded
Milestone
February 2023

Comments

@amunger
Copy link
Contributor

amunger commented Jan 24, 2023

Testing #172103

  1. open a notebook in a new workspace
  2. click run on a cell, this should pop-up the kernel selection
  3. close the kernel selection quickpick without selecting anything
    🐛 cell appears to be running, and cannot be stopped or run again
@DonJayamanne DonJayamanne added this to the January 2023 milestone Jan 24, 2023
rebornix added a commit that referenced this issue Jan 25, 2023
@rebornix
Fix #172244. Handle quick pick hide by escape key in kernel picker.
cbfa2d9
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 25, 2023
@amunger
Copy link
Contributor Author

amunger commented Jan 27, 2023

works correctly when cancelling on the initial quickpick, but not when cancelling in a later stage:
cancelKernelSelection

@amunger amunger reopened this Jan 27, 2023
@amunger amunger added bug Issue identified by VS Code Team member as probable bug verification-found Issue verification failed labels Jan 27, 2023
@VSCodeTriageBot VSCodeTriageBot removed the insiders-released Patch has been released in VS Code Insiders label Jan 27, 2023
@amunger
Copy link
Contributor Author

amunger commented Jan 27, 2023

the cell never ends up running in that gif

@rebornix rebornix modified the milestones: January 2023, February 2023 Jan 27, 2023
rebornix added a commit that referenced this issue Feb 1, 2023
@rebornix
Re #172244. Kernel source command execution can throw error.
804375e
@rebornix rebornix mentioned this issue Feb 1, 2023
Closed
8 tasks
rebornix added a commit to microsoft/vscode-jupyter that referenced this issue Feb 1, 2023
@rebornix
Fix microsoft/vscode#172244. Rethrow cancel error when users dismiss …
3cc8aa6 
…kernel quick pick.
rebornix added a commit that referenced this issue Feb 1, 2023
@rebornix
Re #172244. Kernel source command execution can throw error. (#172986)
d208eec
rebornix added a commit that referenced this issue Feb 1, 2023
@rebornix
Fix #172244. MRU should not pick suggestion when users cancel.
8a9f6c5
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Feb 1, 2023
@rebornix rebornix removed the verification-found Issue verification failed label Feb 2, 2023
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 3, 2023
@amunger amunger added the verified Verification succeeded label Feb 21, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-kernel-picker verified Verification succeeded
Projects
None yet
Milestone
February 2023
5 participants
@roblourens @rebornix @DonJayamanne @amunger @VSCodeTriageBot