Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folding / unfolding is not being read out by screen reader #17257

Closed
WiproPSAccTest opened this issue Dec 15, 2016 · 3 comments · Fixed by #76979
Closed

Folding / unfolding is not being read out by screen reader #17257

WiproPSAccTest opened this issue Dec 15, 2016 · 3 comments · Fixed by #76979
Assignees
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues editor-folding Editor code folding issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded windows VS Code on Windows issues
Milestone

Comments

@WiproPSAccTest
Copy link

WiproPSAccTest commented Dec 15, 2016

VS Code Version: 1.6.1
OS Version:1607
NVDA version:-2016.2.1

Steps to Reproduce:
1.Open VS code editor.
2.Navigate to one of the editor.
3. Navigate to a Bracket present in the file and see the matched bracket highlighted and observe NVDA announcement.
4. Navigate to the Name which you want to change and Press Options button or Right Click and select Change all Occurrences and Hit Enter and change the Name to Desired Name and observe NVDA announcement.
(Note- Options key is available only in Personal Computer and Not on Laptops)
5. Press f1 and type "Fold" or "Unfold "command in command pallet and Hit Enter and observe NVDA announcement.

Expected result:
NVDA should provide information when two brackets are matched or after changing multiple occurrence or after folding/unfolding

Actual Result:
NVDA is not reciting any information when two brackets are matched or after changing multiple occurrence or after folding/unfolding.
Observation: NVDA announces the command written ">fold" in command pallet when Keyboard focus goes to the options Displayed by Command Pallet

User Impact:
Screen Reader user doesn't get to know when two brackets are matched or after changing multiple occurrence or after folding/unfolding.

Attachments:
nvda announces the command in the command pallete for all options displayed by command pallete
nvda is not reciting any information after changing multiple occurance
nvda is not reciting any information after folding a file
nvda is not reciting any information after unfolding a file
nvda is not reciting any information when two brackets are matched

@kieferrm kieferrm added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Dec 16, 2016
@alexdima alexdima added the editor-contrib Editor collection of extras label Mar 2, 2017
@alexdima alexdima added this to the Backlog milestone Mar 2, 2017
@rebornix rebornix added the feature-request Request for new features or functionality label Apr 19, 2017
@alexdima alexdima removed their assignment Nov 24, 2017
@chrmarti chrmarti added the a11ymas Issue from accessibility team label Oct 3, 2018
@alexdima alexdima added editor-bracket-matching Editor brace matching and removed editor-contrib Editor collection of extras labels Nov 14, 2018
@isidorn isidorn added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues and removed accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Jun 19, 2019
@isidorn
Copy link
Contributor

isidorn commented Jul 5, 2019

Reading every time a bracket gets matched can be too noisy.
However reading something when we fold / unfold I think makes perfect sense
@aeschli could we do some annoucment when a region folds / unfolds, like the start and end of a region?

Assigning to july, and also to myself (in case you do not have time could you provide some code pointers)

@isidorn isidorn changed the title Usability: NVDA is not reciting any information when two brackets are matched or after changing multiple occurance or after folding/unfolding. Folding / unfolding is not being read out by screen reader Jul 5, 2019
@isidorn isidorn assigned isidorn and aeschli and unassigned rebornix Jul 5, 2019
@isidorn isidorn added editor-folding Editor code folding issues and removed editor-bracket-matching Editor brace matching labels Jul 5, 2019
@isidorn isidorn modified the milestones: Backlog, July 2019 Jul 5, 2019
@aeschli
Copy link
Contributor

aeschli commented Jul 8, 2019

When detecting a screen reader, we enter 'accessibility mode' and turn folding off.
Maybe we also need to disable the commands in the command menu?

@isidorn
Copy link
Contributor

isidorn commented Jul 8, 2019

@aeschli oh yeah I forgot about that.
Yeah just disable the commands in the command palette via context key.

@aeschli aeschli added the verification-needed Verification of issue is requested label Jul 30, 2019
@lramos15 lramos15 added the verified Verification succeeded label Jul 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 24, 2019
@isidorn isidorn added the windows VS Code on Windows issues label Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues editor-folding Editor code folding issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants