Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix active list icon foreground in light+ v2 theme #172668

Merged
merged 1 commit into from Feb 7, 2023
Merged

Fix active list icon foreground in light+ v2 theme #172668

merged 1 commit into from Feb 7, 2023

Conversation

daviddossett
Copy link
Contributor

@daviddossett daviddossett commented Jan 27, 2023 •
edited

Fix #172447 and #173238

@daviddossett daviddossett enabled auto-merge (squash) January 27, 2023 19:37
@daviddossett daviddossett self-assigned this Jan 27, 2023
@Tyriar Tyriar disabled auto-merge January 27, 2023 20:08
Tyriar
Tyriar approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabled auto merge as this doesn't meet the bar for merge after testing imo

@daviddossett daviddossett mentioned this pull request Feb 6, 2023
Closed
@daviddossett daviddossett merged commit 6a42d4e into main Feb 7, 2023
@daviddossett daviddossett deleted the ddossett/narrow-fowl branch February 7, 2023 17:12
@daviddossett daviddossett mentioned this pull request Feb 7, 2023
Closed
@Tyriar Tyriar added this to the February 2023 milestone Feb 7, 2023
@Tyriar Tyriar mentioned this pull request Feb 8, 2023
Closed
c-claeys pushed a commit to c-claeys/vscode that referenced this pull request Feb 16, 2023
@daviddossett @c-claeys
Fix active list icon foreground in light+ v2 theme (microsoft#172668)
f1512a8
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@daviddossett daviddossett

Labels
None yet
Projects
None yet
Milestone
February 2023
Development

Successfully merging this pull request may close these issues.

Light V2: Poor contast on extension verification badge
2 participants
@daviddossett @Tyriar