Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setting to disable Auto-Detection of High Contrast #17279

Closed
default0 opened this issue Dec 15, 2016 · 5 comments · Fixed by #17394
Closed

Add a setting to disable Auto-Detection of High Contrast #17279

default0 opened this issue Dec 15, 2016 · 5 comments · Fixed by #17394
Assignees
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@default0
Copy link

  • VSCode Version: 1.8.0
  • OS Version: Windows Version 6.3.9600 (Windows 8.1 Enterprise)

Steps to Reproduce:

  1. Enable High Contrast on Windows
  2. Start VS Code, look at the glorious High Contrast theme
  3. Select a different theme, because you would rather work in that
  4. Restart VS Code, your theme choice gets overridden.

Essentially, I'd like to be able to disable the auto-detection of the High Contrast theme I'm using in Windows via some setting, because while I prefer Windows in High Contrast mode, I dislike looking at VS Code's High Contrast theme.

@geirsagberg
Copy link
Contributor

I wholeheartedly agree. I'm okay with the default being auto-detection, for the accessibility scenario, but it should definitely be possible to disable this functionality via settings.

@bpasero bpasero added the feature-request Request for new features or functionality label Dec 16, 2016
@bpasero bpasero added this to the January 2017 milestone Dec 16, 2016
@bpasero
Copy link
Member

bpasero commented Dec 16, 2016

An option makes sense to me. If someone wants to provide a PR 👍

@bpasero bpasero added the help wanted Issues identified as good community contribution opportunities label Dec 16, 2016
@geirsagberg
Copy link
Contributor

@bpasero Done, #17394.

@bpasero bpasero added verification-needed Verification of issue is requested and removed help wanted Issues identified as good community contribution opportunities labels Dec 16, 2016
@bpasero bpasero changed the title Disable Auto-Detection of High Contrast Add a setting to disable Auto-Detection of High Contrast Dec 16, 2016
@geirsagberg
Copy link
Contributor

Could you please re-open this issue?

Unfortunately, my PR only affected the high-contrast swap that occurred when changing Windows theme while VSCode is open, not the initial theme that is set when VSCode starts, or opens a new folder.

I have added a new PR #17832 that completes the fix.

@bpasero bpasero reopened this Jan 1, 2017
@bpasero bpasero closed this as completed Jan 3, 2017
@bpasero
Copy link
Member

bpasero commented Jan 23, 2017

  • To verify (Windows):
    Normally VS Code switches to HC mode automatically when windows is running in HC mode. Verify this new setting can be used to prevent this automatic switch from happening (both on startup as well as when Code is running and you change HC mode in Windows).

@roblourens roblourens added the verified Verification succeeded label Jan 25, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants