Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trouble logging in to export Profile to gist #173380

Closed
bamurtaugh opened this issue Feb 3, 2023 · 3 comments · Fixed by #173428
Closed

Trouble logging in to export Profile to gist #173380

bamurtaugh opened this issue Feb 3, 2023 · 3 comments · Fixed by #173428
Assignees
Labels
authentication Issues with the Authentication platform bug Issue identified by VS Code Team member as probable bug github-authentication Issues with the GitHub Authentication extension insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@bamurtaugh
Copy link
Member

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version:
    Version: 1.76.0-insider (user setup)
    Commit: c4a609f
    Date: 2023-02-03T05:23:17.202Z
    Electron: 19.1.9
    Chromium: 102.0.5005.194
    Node.js: 16.14.2
    V8: 10.2.154.23-electron.0
    OS: Windows_NT x64 10.0.25281
    Sandboxed: Yes
  • OS Version: Windows 11

Steps to Reproduce:

  1. Export a Profile
  2. Brought to browser to grant VS Code auth access, accept it and return to VS Code
  3. I'm prompted there was trouble and to try another way
  4. I try the other way, but I'm presented the same toast
  5. I try another way for a second time, and this time I'm provided a code To finish authenticating, navigate to GitHub and paste in the above one-time code.
  6. It ultimately succeeded on the third try

I'm logged into other extensions with GitHub, and I didn't see this flow today for other fresh logins (nor have I seen it in the past).

I'm including my GitHub Auth output logs. It looks like I got [error] FetchError: request to http://localhost:3000/codeExchangeProxyEndpoints/github/login/oauth/access_token failed, reason: connect ECONNREFUSED 127.0.0.1:3000 twice.

GH-log-feb-3.txt

@bamurtaugh bamurtaugh added user-profiles User profile management github-authentication Issues with the GitHub Authentication extension labels Feb 3, 2023
@TylerLeonhardt
Copy link
Member

🤦‍♂️ nice find. I was typing too fast.

@TylerLeonhardt TylerLeonhardt added authentication Issues with the Authentication platform bug Issue identified by VS Code Team member as probable bug and removed user-profiles User profile management labels Feb 4, 2023
TylerLeonhardt added a commit that referenced this issue Feb 4, 2023
TylerLeonhardt added a commit that referenced this issue Feb 4, 2023
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Feb 4, 2023
@VSCodeTriageBot VSCodeTriageBot added this to the February 2023 milestone Feb 4, 2023
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 6, 2023
c-claeys pushed a commit to c-claeys/vscode that referenced this issue Feb 16, 2023
@joyceerhl joyceerhl added the verified Verification succeeded label Feb 23, 2023
@joyceerhl
Copy link
Contributor

@TylerLeonhardt is it an issue that we hardcode a reference to stable vscode.dev even when we are running VS Code Insiders: https://github.com/microsoft/vscode/pull/173428/files

@TylerLeonhardt
Copy link
Member

@joyceerhl it was a decision to do so for simplicity. At some point maybe insiders should use insiders but consisting the route doesn't change often it's not a big deal

@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
authentication Issues with the Authentication platform bug Issue identified by VS Code Team member as probable bug github-authentication Issues with the GitHub Authentication extension insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants