cells show symbol occurrence highlighting when in command mode

[indirectlylit]

Environment data

• VS Code version: 1.73.1 1.75.0
• Jupyter Extension version (available under the Extensions sidebar): v2022.9.1303220346
• Python Extension version (available under the Extensions sidebar): v2022.18.2
• OS (Windows | Mac | Linux distro) and version: Mac
• Python and/or Anaconda version: 3.10
• Type of virtual environment used (N/A | venv | virtualenv | conda | ...): Docker
• Jupyter server running: Local

Expected behaviour

VS Code provides occurrence highlighting of the symbol currently under the visible cursor. (Enabled by default as setting editor.occurrencesHighlight). This is useful when a cell is in edit mode.

When the cursor is not visible because a cell is in command mode, these highlights are no longer relevant or meaningful and should be hidden with the cursor.

Actual behaviour

Occurrence highlighting persists even in command mode, leading to highlights which confusingly look like find/search results.

Steps to reproduce:

• Enter some code in a cell
• Leave the cursor over a symbol
• Switch to command mode
• The cursor gets hidden but the highlights persist

[VSCodeTriageBot]

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.75.0. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

[indirectlylit]

Upgraded to 1.75.0 and the issue remains.

[roblourens]

This has bugged me too, do you know if there is a way to clear these @rebornix ?

[rebornix]

@roblourens the symbol/word highlight is not cleared when the editor loses focus, which is expected in a normal text editor but not in a cell editor I guess. We need to check if the contrib allows us to clear/hide them and reenable when the editor gains focus. I'll check.

[indirectlylit]

the symbol/word highlight is not cleared when the editor loses focus, which is expected in a normal text editor but not in a cell editor I guess

For what it's worth, I would personally expect it to be cleared in both cases because the highlights are meaningless without keyboard focus.

[rebornix]

It makes good sense to me to disable this in notebook. Changing the behavior in Monaco might be breaking. We can see how to expose enable/disable functionalities from the word highlighter contrib.

[indirectlylit]

Thank you both.

Jupyter notebooks + VS Code editor is overall a delightful and polished UX – well done.