Report Issue for Remote extensions doesn't work

[sbatten]

I ran across this while trying to create report issue markdown links for notebooks. Clicking the report issue item in the help section of the remote explorer does nothing and I believe its because of improper arguments format for the report issue command here:

vscode/src/vs/workbench/contrib/remote/browser/remote.ts

Line 411 in bb920e8

await this.commandService.executeCommand('workbench.action.openIssueReporter', [extensionDescription.identifier.value]);

The correct argument is an object with an extensionId property.

[alexr00]

@sbatten this works fine for me on desktop. Were you on web? It looks like that command is implemented differently for web. This seems unexpected.

@bpasero do you own issue.contribution.ts and issue.web.contribution.ts?

[alexr00]

Looks like @TylerLeonhardt might own this.
These are the parts that I would expect to be the same:

vscode/src/vs/workbench/contrib/issue/electron-sandbox/issue.contribution.ts

Lines 23 to 29 in 550fdeb

	CommandsRegistry.registerCommand(OpenIssueReporterActionId, function (accessor, args?: [string] | OpenIssueReporterArgs) {
	const data: Partial<IssueReporterData> = Array.isArray(args)
	? { extensionId: args[0] }
	: args || {};
	return accessor.get(IWorkbenchIssueService).openReporter(data);
	});

vscode/src/vs/workbench/contrib/issue/browser/issue.web.contribution.ts

Lines 26 to 37 in 550fdeb

	CommandsRegistry.registerCommand(OpenIssueReporterActionId, function (accessor, args?: [string] | OpenIssueReporterArgs) {
	let extensionId: string | undefined;
	if (args) {
	if (Array.isArray(args)) {
	[extensionId] = args;
	} else {
	extensionId = args.extensionId;
	}
	}
	return accessor.get(IWorkbenchIssueService).openReporter({ extensionId });
	});

[TylerLeonhardt]

It was me all along 😱 I will change Web to be more like Desktop.

[TylerLeonhardt]

I just debugged this and my issue reporter command is never fired. I think is an issue somewhere in this:

vscode/src/vs/workbench/contrib/remote/browser/remote.ts

Lines 317 to 370 in 7570fad

	async handleClick() {
	const remoteAuthority = this.environmentService.remoteAuthority;
	if (remoteAuthority) {
	for (let i = 0; i < this.remoteExplorerService.targetType.length; i++) {
	if (remoteAuthority.startsWith(this.remoteExplorerService.targetType[i])) {
	for (const value of this.values) {
	if (value.remoteAuthority) {
	for (const authority of value.remoteAuthority) {
	if (remoteAuthority.startsWith(authority)) {
	await this.takeAction(value.extensionDescription, await value.url);
	return;
	}
	}
	}
	}
	}
	}
	} else {
	const virtualWorkspace = getVirtualWorkspaceLocation(this.workspaceContextService.getWorkspace())?.scheme;
	if (virtualWorkspace) {
	for (let i = 0; i < this.remoteExplorerService.targetType.length; i++) {
	for (const value of this.values) {
	if (value.virtualWorkspace && value.remoteAuthority) {
	for (const authority of value.remoteAuthority) {
	if (this.remoteExplorerService.targetType[i].startsWith(authority) && virtualWorkspace.startsWith(value.virtualWorkspace)) {
	await this.takeAction(value.extensionDescription, await value.url);
	return;
	}
	}
	}
	}
	}
	}
	}
	if (this.values.length > 1) {
	const actions = (await Promise.all(this.values.map(async (value) => {
	return {
	label: value.extensionDescription.displayName || value.extensionDescription.identifier.value,
	description: await value.url,
	extensionDescription: value.extensionDescription
	};
	}))).filter(item => item.description);
	if (actions.length) {
	const action = await this.quickInputService.pick(actions, { placeHolder: nls.localize('pickRemoteExtension', "Select url to open") });
	if (action) {
	await this.takeAction(action.extensionDescription, action.description);
	}
	}
	} else {
	await this.takeAction(this.values[0].extensionDescription, await this.values[0].url);
	}

The repro steps:

• don't have a remote workspace open or any workspace open for that matter
• open the remote explorer -> help and feedback -> Report Issue

nothing happens.

[alexr00]

To verify:

• Install at least 2 remote extension
• Reload, and make sure you don't have a remote or virtual workspace open
• Click "Report Issue" from the Remote "Help & Feedback"
• Verify that you get a quick pick.

[alexr00]

Sorry for the false alarm there @TylerLeonhardt !

[meganrogge]

@TylerLeonhardt where is this? Click "Report Issue" from the Remote "Help & Feedback"

[TylerLeonhardt]

In the Remote Explorer at the bottom.