Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS Code in Browser, when webview is active: F1, F5: default is not prevented #174569

Closed
hediet opened this issue Feb 16, 2023 · 6 comments
Closed

VS Code in Browser, when webview is active: F1, F5: default is not prevented #174569

hediet opened this issue Feb 16, 2023 · 6 comments
Assignees
@mjbvz
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug chromium Issues and items related to Chromium verified Verification succeeded web Issues related to running VSCode in the web webview Webview issues
Milestone
February 2024

Comments

@hediet
Copy link
Member

hediet commented Feb 16, 2023

Reproduction steps

  • Open a webview in VS Code browser (e.g. markdown preview in github.dev, you can go to https://github.com/hediet/slideo for that and press ".", the readme should open automatically)
  • Focus the webview
  • press F1

Expected behavior

The command palette opens.

Actual behavior

The chrome help opens.
@mjbvz mjbvz added webview Webview issues web Issues related to running VSCode in the web chromium Issues and items related to Chromium bug Issue identified by VS Code Team member as probable bug labels Feb 20, 2023
@balaji-sivasakthi
Copy link
Contributor

@hediet it's working fine. Please check once again (maybe your focus on browser URL)

@hediet
Copy link
Member Author

hediet commented Aug 10, 2023

It still reproduces. Did you focus the REAMDE.md webview?

@balaji-sivasakthi
Copy link
Contributor

Yes, but I can't reproduce the issue in my browser.

@mjbvz mjbvz added this to the Backlog milestone Dec 6, 2023
@a-stewart a-stewart mentioned this issue Feb 6, 2024
Merged
@a-stewart
Copy link
Contributor

a-stewart commented Feb 6, 2024 •
edited

I can reproduce with F1 and F5 on Chrome/Linux. Created a PR to fix.

@mjbvz mjbvz modified the milestones: Backlog, February 2024 Feb 6, 2024
@mjbvz
Copy link
Contributor

mjbvz commented Feb 21, 2024

Fixed by #204499 I believe

@mjbvz mjbvz closed this as completed Feb 21, 2024
@alexr00
Copy link
Member

alexr00 commented Feb 22, 2024

I can't repro the original issue with stable. @hediet are you able to verify?

@alexr00 alexr00 added the author-verification-requested Issues potentially verifiable by issue author label Feb 22, 2024
@connor4312 connor4312 added the verified Verification succeeded label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjbvz mjbvz

Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug chromium Issues and items related to Chromium verified Verification succeeded web Issues related to running VSCode in the web webview Webview issues
Projects
None yet
Milestone
February 2024
Development

No branches or pull requests
6 participants
@a-stewart @connor4312 @hediet @mjbvz @alexr00 @balaji-sivasakthi