Prevent F1 from opening browser help in webviews #204499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated. |
mjbvz
approved these changes
Feb 6, 2024
|
Thanks! |
hediet
approved these changes
Feb 6, 2024
itsvyle
reviewed
Feb 28, 2024
| */ | ||
| function isRefresh(e) { | ||
| // 116: keyCode of "F5" | ||
| return e.keyCode === 116; |
There was a problem hiding this comment.
Isn't the keyCode property being deprecated, in favor of using the KeyboardEvent.code property?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #162166 and #174569
When in VS Code (web) pressing F1 does not trigger the browser help normally, but it does when in a webview.
Preventing this just requires us to call preventDefault on the event, the same as for ctrl+w and ctrl+n.