Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript auto-imports are listed after deprecated items #174628

Closed
DanielRosenwasser opened this issue Feb 16, 2023 · 2 comments · Fixed by #176322
Closed

TypeScript auto-imports are listed after deprecated items #174628

DanielRosenwasser opened this issue Feb 16, 2023 · 2 comments · Fixed by #176322
Assignees
@mjbvz
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders javascript JavaScript support issues suggest IntelliSense, Auto Complete typescript Typescript support issues verified Verification succeeded
Milestone
March 2023

Comments

@DanielRosenwasser
Copy link
Member

image

For reference:

vscode/extensions/typescript-language-features/src/languageFeatures/completions.ts

Lines 66 to 69 in 56ba527

if (tsEntry.source && tsEntry.hasAction) {
// De-prioritze auto-imports
// https://github.com/microsoft/vscode/issues/40311
this.sortText = '\uffff' + tsEntry.sortText;

Origin of this change: #40311
@mjbvz mjbvz added this to the March 2023 milestone Feb 20, 2023
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues javascript JavaScript support issues suggest IntelliSense, Auto Complete labels Feb 22, 2023
@navya9singh
Copy link
Member

This happens for microsoft/TypeScript#52604 as well. If there is no comma present, then object member completion is listed as the last option, but if there is a comma, then it is the first.

@gabritto gabritto mentioned this issue Feb 23, 2023
Merged
mjbvz added a commit to mjbvz/vscode that referenced this issue Mar 7, 2023
@mjbvz
Always use TS's sort text in TS 5+
5cb8573 
Fixes microsoft#174628
@mjbvz mjbvz mentioned this issue Mar 7, 2023
Merged
mjbvz added a commit to mjbvz/vscode that referenced this issue Mar 7, 2023
@mjbvz
Always use TS's sort text in TS 5+
b4285db 
Fixes microsoft#174628
mjbvz added a commit to mjbvz/vscode that referenced this issue Mar 7, 2023
@mjbvz
Always use TS's sort text in TS 4.9+
7140a53 
Fixes microsoft#174628
mjbvz added a commit that referenced this issue Mar 7, 2023
@mjbvz
Always use TS's sort text in TS 5+ (#176322)
ed43d97 
* Always use TS's sort text in TS 5+

Fixes #174628

* Add missing file
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 7, 2023
@mjbvz mjbvz added the author-verification-requested Issues potentially verifiable by issue author label Mar 20, 2023
@VSCodeTriageBot
Copy link
Collaborator

This bug has been fixed in the latest release of VS Code Insiders!

@DanielRosenwasser, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version fa13bf1 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@DonJayamanne DonJayamanne added the verified Verification succeeded label Mar 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders javascript JavaScript support issues suggest IntelliSense, Auto Complete typescript Typescript support issues verified Verification succeeded
Projects
None yet
Milestone
March 2023
Development

Successfully merging a pull request may close this issue.

Always use TS's sort text in TS 5+ mjbvz/vscode
5 participants
@DanielRosenwasser @DonJayamanne @mjbvz @VSCodeTriageBot @navya9singh