Snippets show in inline suggestions even though they are turned off

[TheColorRed]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: Windows 11
• OS Version: 1.75.1

Steps to Reproduce:

Using the following settings:

1. open a typescript file
2. type fo within a method/function
3. the following gets output (might have to navigate through some of the suggestions) even though snippets are off:

[jrieken]

Thanks for the patience. I cannot reproduce, please share more of your settings that might influence this. Also share data in a copy-paste friendly way (text over images)

[TheColorRed]

@jrieken Here are the settings that I am using to reproduce (all extensions disabled code --disable-extensions):

{
    "editor.inlineSuggest.enabled": true,
    "editor.snippetSuggestions": "none",
    "editor.quickSuggestions": {
        "other": "inline",
        "comments": "inline",
        "strings": "inline"
    },
    "editor.inlineSuggest.showToolbar": "always"
}

Once typing fo and going to the 3rd suggestion, I get this as a suggestion:

[jrieken]

Thanks for clarifying, looks like we aren't passing the filter here:

vscode/src/vs/editor/contrib/suggest/browser/suggestInlineCompletions.ts

Line 178 in d2f8c4f

new CompletionOptions(undefined, undefined, triggerCharacterInfo?.providers),

[amunger]

I can't figure out how to get that ghost text to show up for suggestions to verify this. I've never seen that ghost text for anything but copilot completions
Do I need a suggestion provider extension?

[jrieken]

You are right. I made a refactoring after this fix and that broke this feature 😨 Thanks for the diligence on this one!

[jrieken]

To verify, use the steps from #175190 (comment). Make sure no snippets completions are ghost-texted with "editor.snippetSuggestions": "none" and that they are when the setting is set accordingly

[meganrogge]

I still cannot get snippet completions to show up @jrieken

[jrieken]

@meganrogge You need to say what you are trying because I do see them working just fine

[amunger]

This works correctly for me now, no snippets with "editor.snippetSuggestions": "none",, and they do show up without it.

[jrieken]

Bang on. The whole point is that the editor.snippetSuggestions-setting is honored also for ghost suggestions

[meganrogge]

editor.snippetSuggestions:inline

[jrieken]

@meganrogge this is about ghost text, please see #175190 (comment) and the comment linked from there

[meganrogge]

🤦🏼‍♀️ there was a syntax error in my settings.json file, so the settings did not get applied. Now it works 👍🏼