Quick fix light bulb disappears before it can be clicked

[daviwil]

• VSCode Version: 1.8.0
• OS Version: Windows 10

Steps to Reproduce:

1. Open a file which triggers a quick fix light bulb
2. Hover the mouse over the light bulb
3. Before you click, the light bulb disappears and switches to a breakpoint icon

Filing this on behalf of @wsmelton who filed the issue originally here: PowerShell/vscode-powershell#392

Sometimes the quick fix light bulb isn't clickable in the gutter:

It seems there may be some conflict between the hover handlers of the breakpoint gutter and the lightbulb that should be showing up. Using Ctrl+. on the line invokes the quick fix menu correctly even though the lightbulb isn't clickable.

[alexdima]

I could still reproduce on Linux

[jrieken]

@isidorn We need to sync on this. We both want to use the gutter for additional commands/menus and we should invent something like a editor gutter menu

[isidorn]

@jrieken I am open for suggestions

[jrieken]

@sandy081 sits in the same boot and should also join the party...

[sandy081]

These edit icons are shown only on settings files.. Not sure if we can add break points there

[jrieken]

There is a setting that allows breakpoints everywhere, then hit F9 while the edit icon show and screen cheese. Long story short: There are 3 custom ways to get a context menu and primary command with an icon in the gutter (breakpoints, settings, quick fix) and we should have something real, like a gutter-menu to prevent these collisions and workarounds

[jrieken]

My proposal is to add a new menu ala editor/gutter/context to which we register commands. That menu will always show in the gutter of the active line and preview the first (most important) command in the gutter. Other commands will be in the context menu, like break points do it today.

[isidorn]

@jrieken your proposal makes sense to me. We can look into this tomorrow in the office, or some time next week when it suits you.

[jrieken]

After understanding the whole richness and complexity of the debug glyph margin decoration we figured it's too much for the menu-story... Instead the light bulb uses the same implementation approach debug uses and therefore conflicts don't happen. Also, debug must check if a line has already a glyph margin decoration before adding one on mouse move, similar check before clicking...

My old code to check if the glyph margin has space. fyi @isidorn

private _hasSpaceInGlyphMargin(line: number): boolean {
	if (!this._editor.getRawConfiguration().glyphMargin) {
		return false;
	}
	const decorations = this._editor.getLineDecorations(line);
	if (decorations) {
		for (const {options} of decorations) {
			if (options.glyphMarginClassName) {
				return false;
			}
		}
	}
	return true;
}

[sandy081]

@jrieken Do I need to do the same for Settings?

[isidorn]

@sandy081 for now we can survive without that. Breakpoints will hide if there are any other decoarions on the line including yours

[jrieken]

Breakpoints will hide if there are any other decoarions on the line including yours

Given @sandy081 uses a decoration to get wrench-icon into the glyph margin

[isidorn]

@sandy081 ok so at least you should use an editor decoration with the glyp margin options to align with the rest of us

[sandy081]

Ok. Will adopt. Reopening it.

[sandy081]

Adopted to use decorations. Closing it.

[alexdima]

Works nicely now. Nice job!