Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform error format is not covered by error renderer #175896

Closed
orgads opened this issue Mar 2, 2023 · 3 comments · Fixed by #175906
Closed

Terraform error format is not covered by error renderer #175896

orgads opened this issue Mar 2, 2023 · 3 comments · Fixed by #175906
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-links verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@orgads
Copy link
Contributor

orgads commented Mar 2, 2023

Type: Bug

Terraform errors format has no comma or colon between the file name and the line number.

Example:

│ Error: Invalid reference
│
│   on main.tf line 2, in locals:
│    2:   foo = abcd

This format is not covered by the built-in error renderer in VS Code.

VS Code version: Code 1.76.0 (92da948, 2023-03-01T10:22:44.506Z)
OS version: Windows_NT x64 10.0.19043
Modes:
Sandboxed: Yes

orgads added a commit to orgads/vscode that referenced this issue Mar 2, 2023
Terraform output.

Example:
│ Error: Invalid reference
│
│   on main.tf line 2, in locals:
│    2:   foo = abcd

Fixes microsoft#175896
orgads added a commit to orgads/vscode that referenced this issue Mar 3, 2023
Terraform output.

Example:
│ Error: Invalid reference
│
│   on main.tf line 2, in locals:
│    2:   foo = abcd

Fixes microsoft#175896
orgads added a commit to orgads/vscode that referenced this issue Mar 6, 2023
Terraform output.

Example:
│ Error: Invalid reference
│
│   on main.tf line 2, in locals:
│    2:   foo = abcd

Fixes microsoft#175896
@alexr00
Copy link
Member

alexr00 commented Mar 6, 2023

/gifplease

@VSCodeTriageBot
Copy link
Collaborator

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.

If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.

Happy coding!

@VSCodeTriageBot VSCodeTriageBot added the info-needed Issue requires more information from poster label Mar 6, 2023
@orgads
Copy link
Contributor Author

orgads commented Mar 6, 2023

I refer to the terminal auto-link feature. I pushed a fix proposal in #175906.

Here's a demo. I expect the link to include main.tf line 2, and open the file in line 2. Instead, the line number is not parsed as expected, so clicking main.tf just opens the file, but not at this line.

terraform-err

@alexr00 alexr00 assigned Tyriar and unassigned alexr00 Mar 6, 2023
@alexr00 alexr00 removed info-needed Issue requires more information from poster triage-needed labels Mar 6, 2023
@Tyriar Tyriar added feature-request Request for new features or functionality terminal-links labels Mar 6, 2023
@Tyriar Tyriar added this to the March 2023 milestone Mar 6, 2023
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 6, 2023
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Mar 20, 2023
@connor4312 connor4312 added the verified Verification succeeded label Mar 21, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-links verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants