Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LinkParsing: Support "foo line 123" #175906

Merged
merged 1 commit into from Mar 6, 2023
Merged

LinkParsing: Support "foo line 123" #175906

merged 1 commit into from Mar 6, 2023

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Mar 2, 2023

Terraform output.

Example:

│ Error: Invalid reference
│
│   on main.tf line 2, in locals:
│    2:   foo = abcd

Fixes #175896

@orgads
LinkParsing: Support "foo line 123"
80ceaeb 
Terraform output.

Example:
│ Error: Invalid reference
│
│   on main.tf line 2, in locals:
│    2:   foo = abcd

Fixes microsoft#175896
@orgads
Copy link
Contributor Author

orgads commented Mar 6, 2023

@Tyriar Can you please review?

@alexr00 alexr00 assigned Tyriar and unassigned alexr00 Mar 6, 2023
@orgads orgads mentioned this pull request Mar 6, 2023
Closed
@Tyriar Tyriar added this to the March 2023 milestone Mar 6, 2023
Tyriar
Tyriar approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good 👍

@Tyriar Tyriar merged commit 6f20c42 into microsoft:main Mar 6, 2023
@orgads orgads deleted the terraform-links branch March 6, 2023 15:27
@orgads
Copy link
Contributor Author

orgads commented Mar 6, 2023

cc @yoshigev

@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

@lramos15 lramos15 lramos15 approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
March 2023
Development

Successfully merging this pull request may close these issues.

Terraform error format is not covered by error renderer
4 participants
@orgads @Tyriar @lramos15 @alexr00