Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree find dismiss is still animated with Workbench: Reduce Motion #175983

Closed
mjbvz opened this issue Mar 3, 2023 · 0 comments · Fixed by #175987
Closed

Tree find dismiss is still animated with Workbench: Reduce Motion #175983

mjbvz opened this issue Mar 3, 2023 · 0 comments · Fixed by #175987
Assignees
@mjbvz
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
March 2023

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Mar 3, 2023

Type: Bug

  1. "workbench.reduceMotion": "on"
  2. Show then hide the find widget in the explorer

Bug
Dismiss is still animated

VS Code version: Code - Insiders 1.77.0-insider (Universal) (155cd6d, 2023-03-02T12:44:52.544Z)
OS version: Darwin x64 22.3.0
Modes:
Sandboxed: Yes

System Info
Item Value
CPUs Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off
Load (avg) 3, 3, 4
Memory (System) 32.00GB (0.09GB free)
Process Argv --crash-reporter-id 48781ca2-1705-4f64-9bab-325055aab55d
Screen Reader no
VM 0%
@mjbvz mjbvz self-assigned this Mar 3, 2023
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Mar 3, 2023
@mjbvz mjbvz added this to the March 2023 milestone Mar 3, 2023
@mjbvz mjbvz added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Mar 3, 2023
mjbvz added a commit to mjbvz/vscode that referenced this issue Mar 3, 2023
@mjbvz
Don't animate tree find widget in reduced motion
a042164 
Fixes microsoft#175983
This was referenced Mar 3, 2023
Merged
Closed
mjbvz added a commit that referenced this issue Mar 7, 2023
@mjbvz
Don't animate tree find widget in reduced motion mode (#175987)
53283c6 
Don't animate tree find widget in reduced motion

Fixes #175983
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 7, 2023
@meganrogge meganrogge added the verified Verification succeeded label Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjbvz mjbvz

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
March 2023
Development

Successfully merging a pull request may close this issue.

Don't animate tree find widget in reduced motion mode mjbvz/vscode
3 participants
@mjbvz @meganrogge @VSCodeTriageBot