Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll sync not working properly for collapsed markdown details blocks #176538

Closed
mjbvz opened this issue Mar 8, 2023 · 2 comments · Fixed by #176541
Closed

Scroll sync not working properly for collapsed markdown details blocks #176538

mjbvz opened this issue Mar 8, 2023 · 2 comments · Fixed by #176541
Assignees
@mjbvz
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders markdown Markdown support issues verified Verification succeeded
Milestone
March 2023

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Mar 8, 2023 •
edited

Thanks @mjbvz for the quick turnaround on preserving the open attribute! I'm still a little curious about the scrolling sync: I don't see anything in #176330 that looks like it would address the issue I'm seeing "scrolling past" a collapsed <details> block where the code cursor makes the preview act as if it's much further down, seemingly by about as much as the length of the expanded <details>.

I can now leave my <details> expanded to re-enable sync'd scrolling, but I was wondering if the intent was to not change the behavior when they're closed? Or, would it be helpful if I broke that part out into a new issue?

Originally posted by @sethp in #175353 (comment)
@mjbvz mjbvz self-assigned this Mar 8, 2023
@mjbvz mjbvz changed the title Scroll sync not working properly for markdown details blocks Scroll sync not working properly for collapsed markdown details blocks Mar 8, 2023
@mjbvz mjbvz added this to the March 2023 milestone Mar 8, 2023
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues labels Mar 8, 2023
@mjbvz
Copy link
Contributor Author

mjbvz commented Mar 8, 2023

@sethp Thanks. I've extracted this to it's own issue and will push a fix shortly

mjbvz added a commit to mjbvz/vscode that referenced this issue Mar 8, 2023
@mjbvz
Don't scroll sync to elements inside collapsed details sections
71504b5 
Fixes microsoft#176538

Turns out that `getClientBoundingRect` returns weird bounds for elements inside of a collapsed details section
@mjbvz mjbvz mentioned this issue Mar 8, 2023
Merged
mjbvz added a commit that referenced this issue Mar 8, 2023
@mjbvz
Don't scroll sync to elements inside collapsed details sections (#176541
924ee8b 
)

Fixes #176538

Turns out that `getClientBoundingRect` returns weird bounds for elements inside of a collapsed details section
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 8, 2023
@mjbvz mjbvz added the author-verification-requested Issues potentially verifiable by issue author label Mar 20, 2023
@VSCodeTriageBot
Copy link
Collaborator

This bug has been fixed in the latest release of VS Code Insiders!

@mjbvz, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version fa13bf1 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@connor4312 connor4312 added the verified Verification succeeded label Mar 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders markdown Markdown support issues verified Verification succeeded
Projects
None yet
Milestone
March 2023
Development

Successfully merging a pull request may close this issue.

Don't scroll sync to elements inside collapsed details sections mjbvz/vscode
3 participants
@connor4312 @mjbvz @VSCodeTriageBot